Skip to content

Log InvalidRequestException from FrontController validation failure to debug log #25600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

marcusirgens
Copy link

@marcusirgens marcusirgens commented Nov 14, 2019

Description (*)

Logs the exception that occurs when the FrontController validation fails.

Manual testing scenarios (*)

Invoke any controller that causes request valiation to fail. Observe debug logs.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Nov 14, 2019

Hi @marcusirgens. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

Copy link
Member

@rodrigowebjump rodrigowebjump left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @marcusirgens

Thanks for your contribution.

@magento-engcom-team
Copy link
Contributor

Hi @rodrigowebjump, thank you for the review.
ENGCOM-6289 has been created to process this Pull Request
✳️ @rodrigowebjump, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@magento-engcom-team
Copy link
Contributor

@marcusirgens thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@rodrigowebjump rodrigowebjump added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Nov 15, 2019
@engcom-Alfa engcom-Alfa self-assigned this Nov 15, 2019
@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

Before:
before

After:
after

@engcom-Foxtrot engcom-Foxtrot self-assigned this Nov 15, 2019
magento-engcom-team pushed a commit that referenced this pull request Nov 19, 2019
@magento-engcom-team magento-engcom-team merged commit 510310b into magento:2.3-develop Nov 19, 2019
@m2-assistant
Copy link

m2-assistant bot commented Nov 19, 2019

Hi @marcusirgens, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@VladimirZaets
Copy link
Contributor

Covered by automated tests in the scope of PR #25704

@VladimirZaets VladimirZaets added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Nov 22, 2019
engcom-Foxtrot pushed a commit to p-bystritsky/magento2 that referenced this pull request Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: App Progress: accept Release Line: 2.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants