-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Relocate Watermark insert on image after resize. #25514 #25528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @Krielkip. Thank you for your contribution
For more details, please, review the Magento Contributor Guide documentation. |
Hi @dmytro-ch, thank you for the review.
|
✔️ QA Passed |
Hi @Krielkip, thank you for your contribution! |
Covered by automated tests in the scope of PR #25704 |
Description (*)
When using watermark on images in Magento 2.3.3, the watermark will be placed on top of the image and then the image will be resized.
If the user uses different size of images, the watermark on the frontend is not consistent on the site.
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Maybe we need to add an option to have either the watermark before or after resizing the image.
Contribution checklist (*)