Skip to content

Relocate Watermark insert on image after resize. #25514 #25528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 14, 2019
Merged

Relocate Watermark insert on image after resize. #25514 #25528

merged 2 commits into from
Nov 14, 2019

Conversation

Krielkip
Copy link
Contributor

@Krielkip Krielkip commented Nov 8, 2019

Description (*)

When using watermark on images in Magento 2.3.3, the watermark will be placed on top of the image and then the image will be resized.
If the user uses different size of images, the watermark on the frontend is not consistent on the site.

Fixed Issues (if relevant)

  1. Image resizing and watermarking do no take into consideration the relative dimensions of the watermark and watermarked image. #25514: Image resizing and watermarking do no take into consideration the relative dimensions of the watermark and watermarked image
  2. The display watermark size is incorrect compared to the original watermark images on list product,product page on magento2.3.2 #23515: The display watermark size is incorrect compared to the original watermark images on list product,product page on magento2.3.2

Manual testing scenarios (*)

  1. Create two products.
  2. Give one product an image of size 400x400.
  3. Give the second product an image of size 1200x1200.
  4. Add a watermark with width 200px.
  5. Refresh image cache.
  6. Generate cached images by visiting the product's product detail page.
  7. Notice that the watermarks are equal of size.

Questions or comments

Maybe we need to add an option to have either the watermark before or after resizing the image.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@Krielkip Krielkip requested a review from buskamuza as a code owner November 8, 2019 11:16
@m2-assistant
Copy link

m2-assistant bot commented Nov 8, 2019

Hi @Krielkip. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-6261 has been created to process this Pull Request
✳️ @dmytro-ch, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@dmytro-ch dmytro-ch added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Nov 11, 2019
@engcom-Alfa engcom-Alfa self-assigned this Nov 11, 2019
@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@m2-assistant
Copy link

m2-assistant bot commented Nov 14, 2019

Hi @Krielkip, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.5 milestone Nov 14, 2019
@VladimirZaets
Copy link
Contributor

Covered by automated tests in the scope of PR #25704

@VladimirZaets VladimirZaets added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests and removed Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests labels Nov 22, 2019
engcom-Foxtrot pushed a commit to p-bystritsky/magento2 that referenced this pull request Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants