Quality Assurance > The use of function sizeof() is discouraged; use count() instead

[lfluvisotto]

Quality Assurance > The use of function sizeof() is discouraged; use count() instead

Description (*)

According to PHP Code Sniffer + Magento Coding Standard

https://github.com/squizlabs/PHP_CodeSniffer/blob/ae3aae46a11e3978f088552160ccca13a01b28e1/src/Standards/Generic/Sniffs/PHP/ForbiddenFunctionsSniff.php#L30

Discourages the use of alias functions. Alias functions are kept in PHP for compatibility with older versions. Can be used to forbid the use of any function.

Fixed Issues (if relevant)

N/A

Manual testing scenarios (*)

N/A

Questions or comments

N/A

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @lfluvisotto. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[ihor-sviziev]

Hi @lfluvisotto,
Your changes looks good, however in files that you’ve changed we have failing static tests. Could you review and fix static tests failures?

[lfluvisotto]

@ihor-sviziev

This is my contribution to solving a part of this Static Tests problem.

Several pull requests from other contributors are not going through Static Tests because the legacy code is not covered by php code sniffer + magento standard coding.

I intend to fix the other violations in other pull requests with specific scopes so as not to get all mixed up and confused.

[ihor-sviziev]

Hi @lfluvisotto,
Unfortunately there is too many places where static tests are failing and it’s almost impossible to fix all the issues together. Because of that we’re running them only for files that were changed in PR. So in scope of this PR please fix failing static tests.

Some pieces could be just ignored if it requires refactoring

Thank you!

[ihor-sviziev]

@magento run all tests

[magento-engcom-team]

Hi @VladimirZaets, thank you for the review.
ENGCOM-6246 has been created to process this Pull Request

[engcom-Alfa]

@magento run all tests

[engcom-Alfa]

✔️ QA Passed

[m2-assistant]

Hi @lfluvisotto, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

[lbajsarowicz]

In my opinion - this line introduces the bug, as previously you had:

$action['url']['params'] = ['a' => 'A', 'b' => 'B'];
$params = ['x' => 'X'];

$params = array_merge($action['url']['params'], $params);

resulted in having keys a, b and x.

The new approach results in:

'x' => 'X',
[
    'a' => 'A',
    'b' => 'B'
]

[ihor-sviziev]

Good catch! Could you create Pull request for that?