Skip to content

"Scheduled Import Settings" should hide fields when "Enabled" is "No" issue25101 #25102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

edenduong
Copy link
Contributor

Description (*)

  1. Resolve "Scheduled Import Settings" should hide fields when "Enabled" is "No" #25101: "Scheduled Import Settings" should hide fields when "Enabled" is "No"

Fixed Issues (if relevant)

  1. "Scheduled Import Settings" should hide fields when "Enabled" is "No" #25101: "Scheduled Import Settings" should hide fields when "Enabled" is "No"

Manual testing scenarios (*)

  1. Go to backend
  2. Store->Configuration
  3. General-> Currency Setup
  4. "Enabled" is "No"

Expected result

  1. Hide the fields

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@edenduong edenduong requested a review from buskamuza as a code owner October 17, 2019 02:52
@m2-assistant
Copy link

m2-assistant bot commented Oct 17, 2019

Hi @edenduong. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

Copy link
Contributor

@Stepa4man Stepa4man left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @edenduong
Thanks for your contribution

@magento-engcom-team
Copy link
Contributor

Hi @Stepa4man, thank you for the review.
ENGCOM-6116 has been created to process this Pull Request
✳️ @Stepa4man, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@engcom-Alfa engcom-Alfa self-assigned this Oct 17, 2019
@Stepa4man Stepa4man added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Oct 17, 2019
@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@engcom-Golf engcom-Golf self-assigned this Oct 17, 2019
magento-engcom-team pushed a commit that referenced this pull request Oct 18, 2019
@magento-engcom-team magento-engcom-team merged commit 1d63bf2 into magento:2.3-develop Oct 18, 2019
@m2-assistant
Copy link

m2-assistant bot commented Oct 18, 2019

Hi @edenduong, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.4 milestone Oct 18, 2019
p-bystritsky added a commit to p-bystritsky/magento2 that referenced this pull request Nov 26, 2019
@VladimirZaets VladimirZaets added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests and removed Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests labels Nov 26, 2019
@VladimirZaets
Copy link
Contributor

Covered by automated tests in PR #25756

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Scheduled Import Settings" should hide fields when "Enabled" is "No"
6 participants