Skip to content

Fix #22747 - JavaScript modules contain unnecessary define checks #24833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 15, 2019
Merged

Fix #22747 - JavaScript modules contain unnecessary define checks #24833

merged 1 commit into from
Oct 15, 2019

Conversation

Bartlomiejsz
Copy link
Contributor

@Bartlomiejsz Bartlomiejsz commented Oct 2, 2019 •
edited
Loading

Description (*)

This is cleanup for #22747

Fixed Issues (if relevant)

  1. JavaScript modules contain unnecessary define checks #22747: JavaScript modules contain unnecessary define checks

Manual testing scenarios (*)

  1. Check files in codebase - Magento JS files used by requireJS shouldn't contain define checks

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@Bartlomiejsz Bartlomiejsz requested a review from DrewML as a code owner October 2, 2019 21:47
@m2-assistant
Copy link

m2-assistant bot commented Oct 2, 2019

Hi @Bartlomiejsz. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@ghost ghost assigned ihor-sviziev Oct 3, 2019
@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-5994 has been created to process this Pull Request
✳️ @ihor-sviziev, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@ihor-sviziev ihor-sviziev added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Oct 3, 2019
@engcom-Alfa engcom-Alfa self-assigned this Oct 9, 2019
@engcom-Alfa
Copy link
Contributor

Hi @Bartlomiejsz. Could you resolve merge conflicts?

@Bartlomiejsz Bartlomiejsz force-pushed the feature/fix_22747_javascript_modules_unnecessary_define_checks branch from 83bbcf1 to 024c101 Compare October 9, 2019 13:03
@Bartlomiejsz
Copy link
Contributor Author

Hi @engcom-Alfa, done

@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-5994 has been created to process this Pull Request

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@engcom-Golf engcom-Golf self-assigned this Oct 10, 2019
magento-engcom-team pushed a commit that referenced this pull request Oct 15, 2019
@VladimirZaets
ENGCOM-5994: Fix #22747 - JavaScript modules contain unnecessary defi…
8f44ec5 
…ne checks #24833
@magento-engcom-team magento-engcom-team merged commit 024c101 into magento:2.3-develop Oct 15, 2019
@m2-assistant
Copy link

m2-assistant bot commented Oct 15, 2019

Hi @Bartlomiejsz, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.4 milestone Oct 15, 2019
@Bartlomiejsz Bartlomiejsz deleted the feature/fix_22747_javascript_modules_unnecessary_define_checks branch October 15, 2019 07:27
@Bartlomiejsz Bartlomiejsz mentioned this pull request Nov 26, 2019
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihor-sviziev ihor-sviziev ihor-sviziev approved these changes

@DrewML DrewML Awaiting requested review from DrewML

Assignees

@ihor-sviziev ihor-sviziev

@engcom-Alfa engcom-Alfa

@engcom-Golf engcom-Golf

Labels
Area: Frontend Area: Lib/Frontend Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Cleanup Component: Authorizenet Component: Backend Component: Catalog Component: Payment Progress: accept Release Line: 2.3 Squashtoberfest 2019
Projects
None yet
Milestone
Release: 2.3.4
Development

Successfully merging this pull request may close these issues.
5 participants
@Bartlomiejsz @magento-engcom-team @engcom-Alfa @ihor-sviziev @engcom-Golf