Skip to content

Extra space from left in top message section (Notification section) #20962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 12, 2019
Merged

Extra space from left in top message section (Notification section) #20962

merged 1 commit into from
Feb 12, 2019

Conversation

cedarvinda
Copy link
Member

Extra space from left in top message section (Notification section)

Description (*)

Extra space from left in top message section (Notification section)

Manual testing scenarios (*)

  1. Open admin panel and login
  2. wait in dashboard notification will show tin top of the page (ref screenshot)

Expected result (*)

sol

Actual result (*)

issue

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Extra space from left in top message section (Notification section)
@magento-engcom-team
Copy link
Contributor

Hi @cedarvinda. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@torhoehn
Copy link
Contributor

torhoehn commented Feb 4, 2019

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @torhoehn. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @torhoehn, here is your new Magento instance.
Admin access: https://pr-20962.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@torhoehn torhoehn added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Feb 4, 2019
@magento-engcom-team
Copy link
Contributor

Hi @torhoehn, thank you for the review.
ENGCOM-4119 has been created to process this Pull Request

@magento-engcom-team magento-engcom-team merged commit caaf53d into magento:2.3-develop Feb 12, 2019
@ghost
Copy link

ghost commented Feb 12, 2019

Hi @cedarvinda, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants