Skip to content

[Backport] Fix issue with file uploading if an upload field is disabled #20636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

serhiyzhovnir
Copy link

Original Pull Request

#20461

Description (*)

Fixed the issue with file uploading if an upload field is disabled.

Fixed Issues (if relevant)

  1. Image gets uploaded if field is disable in Category #20376: Image gets uploaded if a field is disabled in Category

Manual testing scenarios (*)

  1. Login to admin panel
  2. Goto Catalog present on left
  3. Then goto Categories
  4. Select Dafault category
  5. Change Store View to Default Store view
  6. Now click to content tab
  7. then click Browse to find or drag image here, it will not work untill we don't remove the tick from the Use Default Value
  8. But when we simply drags a image on it, then image gets added successfully.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@serhiyzhovnir serhiyzhovnir self-assigned this Jan 26, 2019
@serhiyzhovnir serhiyzhovnir requested a review from rogyar January 26, 2019 17:14
@magento-engcom-team
Copy link
Contributor

Hi @serhiyzhovnir. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added Area: Frontend Component: Ui Release Line: 2.2 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Jan 26, 2019
@serhiyzhovnir
Copy link
Author

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @serhiyzhovnir. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @serhiyzhovnir, here is your new Magento instance.
Admin access: https://pr-20636.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@serhiyzhovnir
Copy link
Author

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @serhiyzhovnir. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @serhiyzhovnir, here is your new Magento instance.
Admin access: https://pr-20636.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@serhiyzhovnir serhiyzhovnir removed their assignment Jan 26, 2019
Copy link
Member

@rodrigowebjump rodrigowebjump left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @serhiyzhovnir Thanks for your contribution.

@magento-engcom-team
Copy link
Contributor

Hi @rodrigowebjump, thank you for the review.
ENGCOM-3973 has been created to process this Pull Request

@ghost
Copy link

ghost commented Jan 29, 2019

Hi @serhiyzhovnir, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Frontend Component: Ui Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants