Fixed 19371-Attribute Heading border misaligned.

[suryakant-krish]

Description (*)

Attribute Heading border misaligned.

Fixed Issues (if relevant)

1. Attribute Heading border misaligned. #19371: Attribute Heading border misaligned.

Manual testing scenarios (*)

1. Login to admin panel > Stores > Attribute sets > choose any attribute.
2. Edit Attribute set name heading border.

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-engcom-team]

Hi @suryakant-krish. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[orlangur]

@suryakant-krish please squash changes into a single commit. Also, note, that nowadays any changes must be delivered to 2.3-develop first.

[sivaschenko]

@suryakant-krish please port this pull request to 2.3-develop branch.

[sidolov]

Hi @suryakant-krish , please, resolve merge conflicts

[suryakant-krish]

@sidolov,

I have resolved conflicts. please review that.

[sivaschenko]

Hi @suryakant-krish thanks for the update! This pull request contains much more changes than #19414, is it intentional? Also can you please check if test fixes applied to 2.3-develop PR should be applied to this pull request as well.

Finally, it would be great to squash changes into a single commit.

[sivaschenko]

Closing this pull request due to inactivity, feel free to reopen if you'd like to continue progress on in

[ghost]

Hi @suryakant-krish, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

[amol2jcommerce]

This message was created automatically by mail delivery software. A message that you sent could not be delivered to one or more of its recipients. This is a temporary error. The following address(es) deferred: amol@twojay.in Domain 2jcommerce.in has exceeded the max emails per hour (251/250 (100%)) allowed. Message will be reattempted later

…

------- This is a copy of the message, including all the headers. ------ Received: from o10.sgmail.github.com ([167.89.101.201]:45579) by mail.2jcommerce.co.uk with esmtps (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.87) (envelope-from <bounces+848413-d057-amol=2jcommerce.in@sgmail.github.com>) id 1gwnx5-000Azv-78 for amol@2jcommerce.in; Thu, 21 Feb 2019 12:59:47 +0000 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=v0c/pgI2i1plM0rIhD4Aft36xn4=; b=XHgAkBxhxFNfvKfu 3l+2qZUWGZCkbry5F57ARfB+6iA8hOd2Tye2SeyExfMw0e97JD2SkXoONfF4ElwE ssfZI0S7Wn7N8BL3cQEjqJ4ewOBCUV1ydu9pVu9K/qvcqfxy+7clLWQiL9oMNstJ UtdDPzNLSA3HgXNmdm117OZfXYY= Received: by filter0251p1iad2.sendgrid.net with SMTP id filter0251p1iad2-12155-5C6EA098-43 2019-02-21 12:59:04.897951725 +0000 UTC m=+1355378.240859507 Received: from github-lowworker-dcd58f3.cp1-iad.github.net (unknown [192.30.252.33]) by ismtpd0050p1iad1.sendgrid.net (SG) with ESMTP id fT-VCyHlSCOUP7fgijKBkQ for <amol@2jcommerce.in>; Thu, 21 Feb 2019 12:59:04.769 +0000 (UTC) Received: from github.com (localhost [127.0.0.1]) by github-lowworker-dcd58f3.cp1-iad.github.net (Postfix) with ESMTP id BA21624089F for <amol@2jcommerce.in>; Thu, 21 Feb 2019 04:59:04 -0800 (PST) Date: Thu, 21 Feb 2019 12:59:04 +0000 (UTC) From: Sergii Ivashchenko <notifications@github.com> Reply-To: magento/magento2 <reply@reply.github.com> To: magento/magento2 <magento2@noreply.github.com> Cc: Subscribed <subscribed@noreply.github.com> Message-ID: <magento/magento2/pull/19373/issue_event/2154881184@github.com> In-Reply-To: <magento/magento2/pull/19373@github.com> References: <magento/magento2/pull/19373@github.com> Subject: Re: [magento/magento2] Fixed 19371-Attribute Heading border misaligned. (#19373) Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="--==_mimepart_5c6ea098b898a_43eb3f99c94d45c013235b"; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: list X-GitHub-Sender: sivaschenko X-GitHub-Recipient: amol2jcommerce X-GitHub-Reason: subscribed List-ID: magento/magento2 <magento2.magento.github.com> List-Archive: https://github.com/magento/magento2 List-Post: <mailto:reply@reply.github.com> List-Unsubscribe: <mailto:unsub+011477e7e74f4b5e49c801468454eb85c8c256634484886c92cf000000011886629892a169ce16e303b9@reply.github.com>, <https://github.com/notifications/unsubscribe/ARR35-GGkagAWT72AnoA2XqZCfcmt_N9ks5vPpgYgaJpZM4YxW8T> X-Auto-Response-Suppress: All X-GitHub-Recipient-Address: amol@2jcommerce.in X-SG-EID: 4LphBs8tVUtWBxn9iIRPK93DMakaxdo1C3jgH5sGtV5cGFhWNyZVfOalu+dWlFsJNFqUlBRk/OKqsj ZtOA7Nlzs4jo/+LfTpntHo3hpkrV/fU3wVM8d81CJZ5YFmo9a4KjRwKupX3H6T8F8cnHm1kgADMqlD CqdCAHoIzoXQb3279TwLkSuKiZqq/56mHrxSdY6Up88hjDKXl2aHjpnecQ6hhM7sYQsGYMGvcM4H0o 4=

----==_mimepart_5c6ea098b898a_43eb3f99c94d45c013235b Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Closed #19373.

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: #19373 (comment) ----==_mimepart_5c6ea098b898a_43eb3f99c94d45c013235b Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit <p>Closed <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="383976377" data-permission-text="Issue title is private" data-url="#19373" data-hovercard-type="pull_request" data-hovercard-url="/magento/magento2/pull/19373/hovercard" href="#19373">#19373</a>.</p> <p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="#19373 (comment)">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ARR35-yYsASG4TDVgmxRkA_5QyCscz1Wks5vPpgYgaJpZM4YxW8T">mute the thread</a>.<img src="https://github.com/notifications/beacon/ARR351lclSCXEn8lOstqStf0-nOf_LIVks5vPpgYgaJpZM4YxW8T.gif" height="1" width="1" alt="" /></p> <script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/magento/magento2","title":"magento/magento2","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/magento/magento2"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Closed #19373."}],"action":{"name":"View Pull Request","url":"#19373 (comment)"}}}</script> <script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "#19373 (comment)", "url": "#19373 (comment)", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script> ----==_mimepart_5c6ea098b898a_43eb3f99c94d45c013235b--

[dipti2jcommerce]

This message was created automatically by mail delivery software. A message that you sent could not be delivered to one or more of its recipients. This is a temporary error. The following address(es) deferred: dipti@twojay.in Domain 2jcommerce.in has exceeded the max emails per hour (250/250 (100%)) allowed. Message will be reattempted later

…

------- This is a copy of the message, including all the headers. ------ Received: from o10.sgmail.github.com ([167.89.101.201]:45038) by mail.2jcommerce.co.uk with esmtps (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.87) (envelope-from <bounces+848413-73f1-dipti=2jcommerce.in@sgmail.github.com>) id 1gwnx5-000Azs-3J for dipti@2jcommerce.in; Thu, 21 Feb 2019 12:59:47 +0000 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=l3uIzmzmFYvbc/5frXwvfU78mM4=; b=fiITTfGqrw9klkwH HR/x6IfpkTaoj0prnA05lZYgM/ARKBYuVtJJdg5Tg70ixwI8uP4J1fWuYh/GIwFU ZmtWqJiAovMQ9Pw5BBgzf2XBrePGIXNd7mlQEEaYQlNH6pvmPgoUW6N6cohvSV7F hVJr9KNpKxFBrE0mfYgbNu/LgGc= Received: by filter0130p1iad2.sendgrid.net with SMTP id filter0130p1iad2-20608-5C6EA098-28 2019-02-21 12:59:04.867892011 +0000 UTC m=+1355739.180095097 Received: from github-lowworker-dcd58f3.cp1-iad.github.net (unknown [192.30.252.33]) by ismtpd0012p1iad1.sendgrid.net (SG) with ESMTP id QB0rv6k-S1yEmINsd68ZaA for <dipti@2jcommerce.in>; Thu, 21 Feb 2019 12:59:04.799 +0000 (UTC) Received: from github.com (localhost [127.0.0.1]) by github-lowworker-dcd58f3.cp1-iad.github.net (Postfix) with ESMTP id C1A0324089F for <dipti@2jcommerce.in>; Thu, 21 Feb 2019 04:59:04 -0800 (PST) Date: Thu, 21 Feb 2019 12:59:04 +0000 (UTC) From: Sergii Ivashchenko <notifications@github.com> Reply-To: magento/magento2 <reply@reply.github.com> To: magento/magento2 <magento2@noreply.github.com> Cc: Subscribed <subscribed@noreply.github.com> Message-ID: <magento/magento2/pull/19373/issue_event/2154881184@github.com> In-Reply-To: <magento/magento2/pull/19373@github.com> References: <magento/magento2/pull/19373@github.com> Subject: Re: [magento/magento2] Fixed 19371-Attribute Heading border misaligned. (#19373) Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="--==_mimepart_5c6ea098c012a_43eb3f99c94d45c013246"; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: list X-GitHub-Sender: sivaschenko X-GitHub-Recipient: dipti2jcommerce X-GitHub-Reason: subscribed List-ID: magento/magento2 <magento2.magento.github.com> List-Archive: https://github.com/magento/magento2 List-Post: <mailto:reply@reply.github.com> List-Unsubscribe: <mailto:unsub+011477eed3c387cc621a1f621cbd08ca74d3ad3c057620e592cf000000011886629892a169ce16e303b9@reply.github.com>, <https://github.com/notifications/unsubscribe/ARR37h90AFNxoCKGj2FVLib-wNJpJpKfks5vPpgYgaJpZM4YxW8T> X-Auto-Response-Suppress: All X-GitHub-Recipient-Address: dipti@2jcommerce.in X-SG-EID: bMwMU6hYaQrzw/g3mau/H2rYSkYIh/tZORRBcROMXDSzjNQsRuNfPoyT8O5y1LilikOgL/Q0ZK8IjX ROUCP6aPQ4valM6ZuntemwCg6j3+JhxRbXJdlialflSZRLu2kyG7Lq0/erIvtWTy3QVZNBdaQMXGUL PLJIXcau2fKw9kN6dv1vYLoZEte/MYyGDWgrWNrKkZodf0QDMeMDY5gxV8Wd80cojHY8W0OoEm7n58 0=

----==_mimepart_5c6ea098c012a_43eb3f99c94d45c013246 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Closed #19373.

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: #19373 (comment) ----==_mimepart_5c6ea098c012a_43eb3f99c94d45c013246 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit <p>Closed <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="383976377" data-permission-text="Issue title is private" data-url="#19373" data-hovercard-type="pull_request" data-hovercard-url="/magento/magento2/pull/19373/hovercard" href="#19373">#19373</a>.</p> <p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="#19373 (comment)">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ARR37l5W3nz1yLC4Tv2EwPmFuUWTpY8Lks5vPpgYgaJpZM4YxW8T">mute the thread</a>.<img src="https://github.com/notifications/beacon/ARR37ioFZiad7JAe1T66LfYgQXWfUf9Wks5vPpgYgaJpZM4YxW8T.gif" height="1" width="1" alt="" /></p> <script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/magento/magento2","title":"magento/magento2","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/magento/magento2"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Closed #19373."}],"action":{"name":"View Pull Request","url":"#19373 (comment)"}}}</script> <script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "#19373 (comment)", "url": "#19373 (comment)", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script> ----==_mimepart_5c6ea098c012a_43eb3f99c94d45c013246--