Skip to content

Fix issue 19286 - Wrong pager style #19296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 24, 2018
Merged

Fix issue 19286 - Wrong pager style #19296

merged 4 commits into from
Nov 24, 2018

Conversation

speedy008
Copy link
Contributor

@speedy008 speedy008 commented Nov 21, 2018 •
edited
Loading

Description (*)

  1. Magento 2.2-Develop

Fixed Issues (if relevant)

  1. Wrong pager style #19286: Wrong pager style

Manual testing scenarios (*)

  1. Add more than 10 order from one account.
  2. Go to -> Myaccount -> My orders
  3. Pagination design of orders tables.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team magento-engcom-team added Partner: Krish TechnoLabs partners-contribution Pull Request is created by Magento Partner labels Nov 21, 2018
@magento-engcom-team
Copy link
Contributor

Hi @speedy008. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@VladimirZaets VladimirZaets self-assigned this Nov 21, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.2.8 milestone Nov 21, 2018
@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-3507 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

@speedy008 thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@rodrigowebjump rodrigowebjump self-assigned this Nov 21, 2018
@magento-engcom-team
Copy link
Contributor

Hi @rodrigowebjump, thank you for the review.
ENGCOM-3507 has been created to process this Pull Request

@rodrigowebjump
Copy link
Member

Hi, @speedy008 Thanks for your contribution.
Please, could you also open a PR for 2.3-develop branch and refer this PR?

@speedy008 speedy008 added the Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release label Nov 21, 2018
@speedy008 speedy008 mentioned this pull request Nov 21, 2018
Merged
4 tasks
@rodrigowebjump rodrigowebjump added Progress: accept and removed Progress: on hold Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Nov 21, 2018
@magento-engcom-team magento-engcom-team mentioned this pull request Nov 24, 2018
Closed
@magento-engcom-team magento-engcom-team merged commit ee0bae8 into magento:2.2-develop Nov 24, 2018
magento-engcom-team pushed a commit that referenced this pull request Nov 24, 2018
@VladimirZaets
ENGCOM-3507: Fix issue 19286 - Wrong pager style #19296
d1c7535
@magento-engcom-team
Copy link
Contributor

Hi @speedy008. Thank you for your contribution.
We will aim to release these changes as part of 2.2.8.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

@speedy008
Copy link
Contributor Author

@magento-engcom-team
I have already port into magento-2.3-develop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodrigowebjump rodrigowebjump rodrigowebjump approved these changes

@VladimirZaets VladimirZaets VladimirZaets approved these changes

Assignees

@rodrigowebjump rodrigowebjump

@VladimirZaets VladimirZaets

Labels
Area: Design/Frontend Award: bug fix Partner: Krish TechnoLabs partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.2
Projects
None yet
Milestone
Release: 2.2.8
Development

Successfully merging this pull request may close these issues.
4 participants
@speedy008 @magento-engcom-team @rodrigowebjump @VladimirZaets