Skip to content

[Backport] fixed Product Advanced Pricing design issue #18775 #18881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

gelanivishal
Copy link
Contributor

@gelanivishal gelanivishal commented Oct 27, 2018

Original PR

#18790

Description (*)

There was a small design issue die to app/code/Magento/Ui/view/base/web/templates/form/field.html file visible="$data.labelVisible" was on child element of the label, because of that parent was still visible even if the label visibility was false.

Fixed Issues (if relevant)

  1. Product Advanced Pricing design issue #18775: Product Advanced Pricing design issue

Manual testing scenarios (*)

  1. login magento admin
  2. goto catalog products
    3: click on Add Product button
    4: fill details then click on Advanced Pricing
    5: in customer group price click Add

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @gelanivishal. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@VladimirZaets VladimirZaets self-assigned this Oct 28, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.2.8 milestone Oct 28, 2018
@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-3310 has been created to process this Pull Request

@sidolov
Copy link
Contributor

sidolov commented Oct 30, 2018

Hi @gelanivishal , we can't reproduce the issue described in the PR. Please, provide additional steps for the issue.
Thank you!

@sivaschenko
Copy link
Member

Hi @gelanivishal , would you like to continue the progress on this PR?

@gelanivishal
Copy link
Contributor Author

Hello @sivaschenko

I can't find error in Codacy/PR Quality Review. If you find it then please guide me.

Thank you.

@sivaschenko
Copy link
Member

Hi @gelanivishal , I believe that there is no need to fix static tests. However, as it was mentioned in #18881 (comment) we cannot reproduce the issue described in your PR.

Could you confirm that the issue is still actual and provide more details for us to be able to reproduce the actual issue and verify the fix. Does it appear only in specific browsers? Could you attach a screenshot?

@sivaschenko sivaschenko self-assigned this Nov 16, 2018
@VladimirZaets
Copy link
Contributor

@gelanivishal, I am closing this PR now due to inactivity.
Please reopen and update if you wish to continue.
Thank you for collaboration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants