-
Notifications
You must be signed in to change notification settings - Fork 9.4k
[Backport] fixed Product Advanced Pricing design issue #18775 #18881
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport] fixed Product Advanced Pricing design issue #18775 #18881
Conversation
Hi @gelanivishal. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
Hi @VladimirZaets, thank you for the review. |
Hi @gelanivishal , we can't reproduce the issue described in the PR. Please, provide additional steps for the issue. |
Hi @gelanivishal , would you like to continue the progress on this PR? |
Hello @sivaschenko I can't find error in Codacy/PR Quality Review. If you find it then please guide me. Thank you. |
Hi @gelanivishal , I believe that there is no need to fix static tests. However, as it was mentioned in #18881 (comment) we cannot reproduce the issue described in your PR. Could you confirm that the issue is still actual and provide more details for us to be able to reproduce the actual issue and verify the fix. Does it appear only in specific browsers? Could you attach a screenshot? |
@gelanivishal, I am closing this PR now due to inactivity. |
Original PR
#18790
Description (*)
There was a small design issue die to app/code/Magento/Ui/view/base/web/templates/form/field.html file visible="$data.labelVisible" was on child element of the label, because of that parent was still visible even if the label visibility was false.
Fixed Issues (if relevant)
Manual testing scenarios (*)
3: click on Add Product button
4: fill details then click on Advanced Pricing
5: in customer group price click Add
Contribution checklist (*)