Fixed issue : Left Side Back End Menu Design fix #18687 #18858

suryakant-krish · 2018-10-27T07:09:23Z

Description (*)

Fixed Left Side Back End Menu Design.

Fixed Issues (if relevant)

Left Side Back End Menu Design fix #18687 : Left Side Back End Menu Design fix

Manual testing scenarios (*)

Added automatic scroll if the menu item is more.

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds on Travis CI are green)

magento-engcom-team · 2018-10-27T07:09:28Z

Hi @suryakant-krish. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento-engcom-team give me test instance - deploy test instance based on PR changes
@magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

magento-engcom-team · 2018-10-28T23:22:26Z

Hi @VladimirZaets, thank you for the review.
ENGCOM-3318 has been created to process this Pull Request

magento-engcom-team · 2018-10-28T23:22:27Z

@suryakant-krish thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

VladimirZaets · 2018-11-05T13:27:01Z

app/design/adminhtml/Magento/backend/Magento_Backend/web/css/source/module/_menu.less

@@ -273,7 +273,16 @@
            > .submenu {
                transform: translateX(0);
                visibility: visible;
-                z-index: @submenu__z-index;
+                z-index: 698;
+                overflow-x: scroll;


Hi @suryakant-krish, thanks for collaboration.

Please use overflow-x: auto instead of scroll. Scroll should be added only in cases when it really need, for this functionality, the better way is to use "overflow-x: auto".

VladimirZaets · 2018-11-05T13:28:26Z

app/design/adminhtml/Magento/backend/Magento_Backend/web/css/source/module/_menu.less

@@ -273,7 +273,16 @@
            > .submenu {
                transform: translateX(0);
                visibility: visible;
-                z-index: @submenu__z-index;
+                z-index: 698;


The better way is to use @submenu__z-indexvariable + 1 instead of hardcode.

VladimirZaets · 2018-11-05T13:30:35Z

app/design/adminhtml/Magento/backend/Magento_Backend/web/css/source/module/_menu.less

+                min-width: 100%;
+                display: block;
+                float: left;
+                max-width: 1640px;


According to Magento frontend dev guide we haven't breakpoint on 1640 window width. Please change it to 1440px

Need update

suryakant-krish · 2018-11-12T05:26:20Z

I have updated code as you have mentioned,

VladimirZaets · 2018-11-19T10:00:40Z

Hi @suryakant-krish, I see that you already fixed code that I am mentioned, but as I see you didn't push changes to PRs branch. You push changes to "fixed-18687" branch, but PR was created from 2.2-develop branch

suryakant-krish · 2018-11-19T10:27:34Z

hi @VladimirZaets
I have updated code in 2.2 develop branch.

suryakant-krish · 2018-11-24T06:14:49Z

Can you please check I have commited all my latest changes.

sivaschenko · 2018-12-05T08:00:54Z

@suryakant-krish thanks for your contribution. We'll first merge your pull request to 2.3 and then process this one.

suryakant-krish · 2018-12-07T06:23:27Z

I have already added forword port for this please check below url.
#19560

[Backport] Fixed 19579: Input type import file alignment issue.

[Backport] Fixed 19573: Alignment Issue when create a new email template admin

[Backport] Fixed icon alignment: Frontend Component theme sort by arrow icon vertical alignment issue. magento#19639

[Backport] Fixed 19791: Logo vertical misalignment.

[Backport] Fixed 19800 Contact us : design improvement

sivaschenko · 2019-01-17T11:22:28Z

Hi @suryakant-krish , I am closing this pull request, as the forward-port to 2.3 was closed. Please feel free to reopen when the forward port pull request will be merged to 2.3-develop.

ghost · 2019-01-17T11:22:33Z

Hi @suryakant-krish, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team added Area: Design/Frontend Release Line: 2.2 labels Oct 27, 2018

VladimirZaets self-assigned this Oct 28, 2018

VladimirZaets previously approved these changes Oct 28, 2018

View reviewed changes

magento-engcom-team added this to the Release: 2.2.8 milestone Oct 28, 2018

VladimirZaets reviewed Nov 5, 2018

View reviewed changes

VladimirZaets added the Progress: needs update label Nov 5, 2018

Fixed magento#18858 Left Side Back End Menu Design fix.

06b7fe1

suryakant-krish added 5 commits November 13, 2018 17:02

Merge branch 'Fixed-18918' into 2.2-develop

1f68acf

Merge branch 'Fixed-18918' into 2.2-develop

d379d7e

Merge branch 'Fixed-18918' into 2.2-develop

6709059

Fixed magento#18858 Left Side Back End Menu Design fix

fd15a89

Merge branch 'fixed-18687' into 2.2-develop

d727064

VladimirZaets changed the base branch from 2.2-develop to 2.3-develop November 19, 2018 09:55

VladimirZaets changed the base branch from 2.3-develop to 2.2-develop November 19, 2018 09:55

Left Side Back End Menu Design fix.

37e3d4e

suryakant-krish added 4 commits November 24, 2018 11:52

Resolved conflict

1d9ba3a

Fix conflict

f61264e

Merge branch 'magento-2.2-develop' into 2.2-develop

30543a6

Merge branch '2.2-develop' into 2.2-develop

9554d0e

suryakant-krish mentioned this pull request Dec 5, 2018

[Forwardport] 18858: Left Side Back End Menu Design fix #19560

Closed

4 tasks

sivaschenko self-assigned this Dec 5, 2018

sivaschenko added the Progress: on hold label Dec 5, 2018

suryakant-krish and others added 21 commits December 10, 2018 05:24

Fixed-19573: Alignment Issue when create a new email template admin.

6055ad9

Fixed-19573: Alignment Issue when create a new email template admin.

1fd71da

Fixed-19573: Alignment Issue when create a new email template admin.

51ce8ad

Fixed 19573: Alignment Issue when create a new email template admin

cde7b2f

Input type import file alignment issue. magento#19579

4cae0bc

Merge branch '2.2-develop' into 2.2-develop-PR-port-19580

6762ee2

Merge branch '2.2-develop' into 2.2-develop-PR-port-19574

3ef0153

Merge pull request #5 from suryakant-krish/2.2-develop-PR-port-19580

2f00729

[Backport] Fixed 19579: Input type import file alignment issue.

Merge pull request #4 from suryakant-krish/2.2-develop-PR-port-19574

dd51440

[Backport] Fixed 19573: Alignment Issue when create a new email template admin

Fixed-icon-alignment: Sort by arrow icon alignment issue.

1a7ef7c

Merge pull request #7 from suryakant-krish/2.2-develop-PR-port-19640

d51f907

[Backport] Fixed icon alignment: Frontend Component theme sort by arrow icon vertical alignment issue. magento#19639

Fixed-19800: Contact us : design improvement.

5bb06c6

Fixed 19800 Contact us : design improvement

e5f14c6

Fixed 19800 Contact us : design improvement

07b73ae

Fixed 19800 Contact us : design improvement

c8191a9

Fixed 19800 Contact us : design improvement

1071096

Fixed 19800 Contact us : design improvement

99ec068

ENGCOM-3763: Static test fix.

2bfa57e

Fixed-19791: Logo vertical misalignment.

9ab19c6

Merge pull request #10 from suryakant-krish/2.2-develop-PR-port-19792

33fa19c

[Backport] Fixed 19791: Logo vertical misalignment.

Merge pull request #9 from suryakant-krish/2.2-develop-PR-port-19803

a721816

[Backport] Fixed 19800 Contact us : design improvement

sivaschenko closed this Jan 17, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fixed issue : Left Side Back End Menu Design fix #18687 #18858

Fixed issue : Left Side Back End Menu Design fix #18687 #18858

Uh oh!

suryakant-krish commented Oct 27, 2018 •

edited

Loading

Uh oh!

magento-engcom-team commented Oct 27, 2018

Uh oh!

magento-engcom-team commented Oct 28, 2018

Uh oh!

magento-engcom-team commented Oct 28, 2018

Uh oh!

VladimirZaets Nov 5, 2018

Uh oh!

VladimirZaets Nov 5, 2018

Uh oh!

VladimirZaets Nov 5, 2018

Uh oh!

suryakant-krish commented Nov 12, 2018

Uh oh!

VladimirZaets commented Nov 19, 2018

Uh oh!

suryakant-krish commented Nov 19, 2018 •

edited

Loading

Uh oh!

suryakant-krish commented Nov 24, 2018

Uh oh!

sivaschenko commented Dec 5, 2018

Uh oh!

suryakant-krish commented Dec 7, 2018

Uh oh!

sivaschenko commented Jan 17, 2019

Uh oh!

ghost commented Jan 17, 2019

Uh oh!

Uh oh!

Fixed issue : Left Side Back End Menu Design fix #18687 #18858

Fixed issue : Left Side Back End Menu Design fix #18687 #18858

Uh oh!

Conversation

suryakant-krish commented Oct 27, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description (*)

Fixed Issues (if relevant)

Manual testing scenarios (*)

Contribution checklist (*)

Uh oh!

magento-engcom-team commented Oct 27, 2018

Uh oh!

magento-engcom-team commented Oct 28, 2018

Uh oh!

magento-engcom-team commented Oct 28, 2018

Uh oh!

VladimirZaets Nov 5, 2018

Choose a reason for hiding this comment

Uh oh!

VladimirZaets Nov 5, 2018

Choose a reason for hiding this comment

Uh oh!

VladimirZaets Nov 5, 2018

Choose a reason for hiding this comment

Uh oh!

suryakant-krish commented Nov 12, 2018

Uh oh!

VladimirZaets commented Nov 19, 2018

Uh oh!

suryakant-krish commented Nov 19, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

suryakant-krish commented Nov 24, 2018

Uh oh!

sivaschenko commented Dec 5, 2018

Uh oh!

suryakant-krish commented Dec 7, 2018

Uh oh!

sivaschenko commented Jan 17, 2019

Uh oh!

ghost commented Jan 17, 2019

Uh oh!

Uh oh!

suryakant-krish commented Oct 27, 2018 •

edited

Loading

suryakant-krish commented Nov 19, 2018 •

edited

Loading