use return value instead of reference parameter #1818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -225,12 +225,12 @@ public function getData($key = '', $index = null) | |||
| * Prepare Data Source | |||
| * | |||
| * @param array $dataSource | |||
| * @return void | |||
| * @return array | |||
| * @SuppressWarnings(PHPMD.UnusedFormalParameter) | |||
There was a problem hiding this comment.
Why should i remove it? The method will return an array.
There was a problem hiding this comment.
I mean @SuppressWarnings(PHPMD.UnusedFormalParameter)
|
accepted |
|
@daniel-rose, thank you for contribution. This PR will be merged soon in scope of MAGETWO-43236 |
|
We have automated a Magento Contributor License Agreement verifier for contributions sent to our GitHub projects. |
magento-team
pushed a commit
that referenced
this pull request
Oct 6, 2015
magento-team
pushed a commit
that referenced
this pull request
Oct 6, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plugins can not listen on methods with reference parameters. The reason for this is the usage of the php function "call_user_func_array". I found this call in the method "___callPlugins" of the trait "Magento\Framework\Interception\Interceptor".
Note on php.net for "call_user_func_array":
Before PHP 5.4, referenced variables in param_arr are passed to the function by reference, regardless of whether the function expects the respective parameter to be passed by reference. This form of call-time pass by reference does not emit a deprecation notice, but it is nonetheless deprecated, and has been removed in PHP 5.4. Furthermore, this does not apply to internal functions, for which the function signature is honored. Passing by value when the function expects a parameter by reference results in a warning and having call_user_func() return FALSE (there is, however, an exception for passed values with reference count = 1, such as in literals, as these can be turned into references without ill effects — but also without writes to that value having any effect —; do not rely in this behavior, though, as the reference count is an implementation detail and the soundness of this behavior is questionable).