Skip to content

[Forwardport] Adjust page-main container height for sticky footer; fixes #15118 #17809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 4, 2018
Merged

[Forwardport] Adjust page-main container height for sticky footer; fixes #15118 #17809

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions app/design/frontend/Magento/blank/Magento_Theme/web/css/source/_module.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,16 @@
.lib-css(background-color, @page__background-color);
}

.page-wrapper {
.lib-vendor-prefix-display(flex);
.lib-vendor-prefix-flex-direction(column);
min-height: 100vh; // Stretch content area for sticky footer
}

.page-main {
.lib-vendor-prefix-flex-grow(1);
}

//
// Header
// ---------------------------------------------
Expand Down Expand Up @@ -279,17 +289,7 @@
// _____________________________________________

.media-width(@extremum, @break) when (@extremum = 'min') and (@break = @screen__m) {

html,
body {
height: 100%; // Stretch screen area for sticky footer
}

.page-wrapper {
.lib-vendor-prefix-display(flex);
.lib-vendor-prefix-flex-direction(column);
min-height: 100%; // Stretch content area for sticky footer

> .breadcrumbs,
> .top-container,
> .widget {
Expand Down
19 changes: 10 additions & 9 deletions app/design/frontend/Magento/luma/Magento_Theme/web/css/source/_module.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,16 @@
.lib-css(background-color, @page__background-color);
}

.page-wrapper {
.lib-vendor-prefix-display(flex);
.lib-vendor-prefix-flex-direction(column);
min-height: 100vh; // Stretch content area for sticky footer
}

.page-main {
.lib-vendor-prefix-flex-grow(1);
}

//
// Header
// ---------------------------------------------
Expand Down Expand Up @@ -411,12 +421,6 @@
}
}
}
.page-footer,
.copyright {
bottom: 0;
position: absolute;
width: 100%;
}
}

.media-width(@extremum, @break) when (@extremum = 'max') and (@break = @screen__s) {
Expand Down Expand Up @@ -614,10 +618,7 @@
}

.page-wrapper {
.lib-vendor-prefix-display(flex);
.lib-vendor-prefix-flex-direction(column);
margin: 0;
min-height: 100%; // Stretch content area for sticky footer
position: relative;
transition: margin .3s ease-out 0s;

Expand Down