-
Notifications
You must be signed in to change notification settings - Fork 9.4k
ConfigurableProduct show prices in select options #17695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ConfigurableProduct show prices in select options #17695
Conversation
- Add feature to show price of customized product in select on product page
Hi @alexeya-ven. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
Hi @VladimirZaets, thank you for the review. |
this.options.priceFormat, | ||
1); | ||
} | ||
} | ||
} | ||
|
||
if (allowedProducts.length > 0) { | ||
options[i].allowedProducts = allowedProducts; | ||
element.options[index] = new Option(this._getOptionLabel(options[i]), options[i].id); | ||
|
||
if (typeof options[i].price !== 'undefined') { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this functionality is never used. Also it has a bug with attribute name (uses prices instead price)
- Fix isShowSign parameter passing that adds "+" or "-" to the option. Previously there was a bug because this parameter should be boolean.
- Remove unused variable
- Fix code style errors
Fix js static test failure
Hi @ihor-sviziev, thank you for the review. |
Hi @alexeya-ven, thanks for collaboration. |
Hi @VladimirZaets |
Hi @alexeya-ven. Thank you for your contribution. Please, consider to port this solution to 2.3 release line. |
Fix js static test failure
… decreases on the configurable attribute dropdown. This fixes a bug introduced in PR magento#17695 as detailed on issue magento#22270
… decreases on the configurable attribute dropdown. This fixes a bug introduced in PR magento#17695 as detailed on issue magento#22270
Description
In Magento2 by default we can't show configurable product prices in select options, as it was done in custom options. There only labels with product name there. My improvement fixes that problem.
Manual testing scenarios
Expected result:
You can see labels with prices
Actual result:
You can see labels without prices, but when you choose some of label, product price is updating
Contribution checklist