Skip to content

Migrating Store Grid to UI Components #17371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Mar 30, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,12 @@
* Store render group
*
* @author Magento Core Team <core@magentocommerce.com>
* @deprecated since Store Grid is refactored with UI Components
*/
class Group extends \Magento\Backend\Block\Widget\Grid\Column\Renderer\AbstractRenderer
{
/**
* {@inheritdoc}
* @inheritdoc
*/
public function render(\Magento\Framework\DataObject $row)
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,12 @@
* Store render store
*
* @author Magento Core Team <core@magentocommerce.com>
* @deprecated since Store Grid is refactored with UI Components
*/
class Store extends \Magento\Backend\Block\Widget\Grid\Column\Renderer\AbstractRenderer
{
/**
* {@inheritdoc}
* @inheritdoc
*/
public function render(\Magento\Framework\DataObject $row)
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,12 @@
* Store render website
*
* @author Magento Core Team <core@magentocommerce.com>
* @deprecated since Store Grid is refactored with UI Components
*/
class Website extends \Magento\Backend\Block\Widget\Grid\Column\Renderer\AbstractRenderer
{
/**
* {@inheritdoc}
* @inheritdoc
*/
public function render(\Magento\Framework\DataObject $row)
{
Expand Down
1 change: 1 addition & 0 deletions app/code/Magento/Backend/Block/System/Store/Store.php
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
* @author Magento Core Team <core@magentocommerce.com>
* @api
* @since 100.0.2
* @deprecated since Store Grid is refactored with UI Components
*/
class Store extends \Magento\Backend\Block\Widget\Grid\Container
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,10 @@
*/
-->
<page xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:View/Layout/etc/page_configuration.xsd">
<update handle="formkey"/>
<update handle="adminhtml_system_store_grid_block"/>
<update handle="styles"/>
<body>
<referenceContainer name="content">
<block class="Magento\Backend\Block\System\Store\Store" name="adminhtml.system.store.container"/>
<uiComponent name="store_listing"/>
</referenceContainer>
</body>
</page>
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,10 @@
<actionGroup ref="LoginAsAdmin" stepKey="loginAsAdmin2"/>
<amOnPage url="{{AdminSystemStorePage.url}}" stepKey="amOnPageAdminSystemStore"/>
<waitForPageLoad stepKey="waitForPageAdminSystemStoreLoad" />
<click selector="{{AdminStoresGridSection.resetButton}}" stepKey="clickOnResetButton"/>
<waitForPageLoad time="10" stepKey="waitForPageAdminStoresGridLoadAfterResetButton"/>
<fillField selector="{{AdminStoresGridSection.storeGrpFilterTextField}}" userInput="Main Website Store" stepKey="fillFieldOnWebsiteStore"/>
<click selector="{{AdminStoresGridSection.searchButton}}" stepKey="clickOnSearchButton"/>
<waitForPageLoad stepKey="waitForPageAdminStoresGridLoadAfterSearchButton"/>
<click selector="{{AdminStoresGridSection.storeGrpNameInFirstRow}}" stepKey="clickOnstoreGrpNameInFirstRow"/>
<actionGroup ref="filterStoresGridByStore" stepKey="enterStoreGroup1Name">
<argument name="store" value="Main Website Store"/>
</actionGroup>
<click selector="{{AdminStoresGridSection.storeInFirstRow}}" stepKey="clickOnstoreInFirstRow"/>
<waitForPageLoad stepKey="waitForPageAdminSystemStoreLoad1" />
<selectOption userInput="Default Category" selector="{{AdminNewStoreGroupSection.storeRootCategoryDropdown}}" stepKey="selectOptionDefaultCategory"/>
<click selector="{{AdminStoreGroupActionsSection.saveButton}}" stepKey="clickSaveStoreButton"/>
Expand Down Expand Up @@ -59,12 +57,11 @@
<!--Assign new created root category to store-->
<amOnPage url="{{AdminSystemStorePage.url}}" stepKey="amOnPageAdminSystemStore"/>
<waitForPageLoad stepKey="waitForPageAdminSystemStoreLoad" />
<click selector="{{AdminStoresGridSection.resetButton}}" stepKey="clickOnResetButton"/>
<waitForPageLoad time="10" stepKey="waitForPageAdminStoresGridLoadAfterResetButton"/>
<fillField selector="{{AdminStoresGridSection.storeGrpFilterTextField}}" userInput="Main Website Store" stepKey="fillFieldOnWebsiteStore"/>
<click selector="{{AdminStoresGridSection.searchButton}}" stepKey="clickOnSearchButton"/>
<actionGroup ref="filterStoresGridByStore" stepKey="enterStoreGroup1Name">
<argument name="store" value="Main Website Store"/>
</actionGroup>
<waitForPageLoad stepKey="waitForPageAdminStoresGridLoadAfterSearchButton"/>
<click selector="{{AdminStoresGridSection.storeGrpNameInFirstRow}}" stepKey="clickOnstoreGrpNameInFirstRow"/>
<click selector="{{AdminStoresGridSection.storeInFirstRow}}" stepKey="clickOnstoreInFirstRow"/>
<waitForPageLoad stepKey="waitForPageAdminStoresGroupEditLoad" />
<selectOption userInput="{{NewRootCategory.name}}" selector="{{AdminNewStoreGroupSection.storeRootCategoryDropdown}}" stepKey="selectOptionCreatedNewRootCategory"/>
<click selector="{{AdminStoreGroupActionsSection.saveButton}}" stepKey="clickSaveStoreButton"/>
Expand All @@ -80,4 +77,4 @@
<argument name="categoryEntity" value="SubCategoryWithParent"/>
</actionGroup>
</test>
</tests>
</tests>
14 changes: 6 additions & 8 deletions app/code/Magento/Catalog/Test/Mftf/Test/DeleteCategoriesTest.xml
Original file line number Diff line number Diff line change
Expand Up @@ -58,19 +58,17 @@
<!-- Change root category for Main Website Store. -->
<amOnPage stepKey="s1" url="{{AdminSystemStorePage.url}}"/>
<waitForPageLoad stepKey="waitForPageAdminSystemStoreLoad" />
<click stepKey="s2" selector="{{AdminStoresGridSection.resetButton}}"/>
<waitForPageLoad stepKey="waitForPageAdminStoresGridLoadAfterResetButton" time="10"/>
<fillField stepKey="s4" selector="{{AdminStoresGridSection.storeGrpFilterTextField}}" userInput="Main Website Store"/>
<click stepKey="s5" selector="{{AdminStoresGridSection.searchButton}}"/>
<waitForPageLoad stepKey="waitForPageAdminStoresGridLoadAfterSearchButton"/>
<click stepKey="s7" selector="{{AdminStoresGridSection.storeGrpNameInFirstRow}}" />
<actionGroup ref="filterStoresGridByStore" stepKey="filterStoresGridByStore">
<argument name="store" value="Main Website Store"/>
</actionGroup>
<click stepKey="s7" selector="{{AdminStoresGridSection.storeInFirstRow}}" />
<waitForPageLoad stepKey="waitForPageAdminStoresGroupEditLoad" />
<selectOption selector="{{AdminNewStoreGroupSection.storeRootCategoryDropdown}}" userInput="{{NewRootCategory.name}}" stepKey="setNewCategoryForStoreGroup"/>
<click selector="{{AdminNewStoreViewActionsSection.saveButton}}" stepKey="clickSaveStoreGroup"/>
<waitForElementVisible selector="{{AdminConfirmationModalSection.ok}}" stepKey="waitForModalSaveStoreGroup"/>
<see selector="{{AdminConfirmationModalSection.title}}" userInput="Warning message" stepKey="seeWarning"/>
<click selector="{{AdminConfirmationModalSection.ok}}" stepKey="acceptModal" />
<waitForElementVisible selector="{{AdminStoresGridSection.storeFilterTextField}}" stepKey="waitForPageAdminStoresGridReload"/>
<waitForElementVisible selector="{{AdminStoresGridFilterSection.filters}}" stepKey="waitForPageAdminStoresGridReload"/>
<see userInput="You saved the store." stepKey="seeSavedMessage"/>

<!-- @TODO: Uncomment commented below code after MQE-903 is fixed -->
Expand Down Expand Up @@ -160,4 +158,4 @@
<click selector="{{AdminCategoryMainActionsSection.SaveButton}}" stepKey="saveCategoryDefaultCategory"/>
<seeElement selector="{{AdminCategoryMessagesSection.SuccessMessage}}" stepKey="assertSuccessMessageAfterSaveDefaultCategory"/>
</test>
</tests>
</tests>
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,18 @@
*/
class Collection extends \Magento\Store\Model\ResourceModel\Website\Collection
{
/**
* @inheritdoc
*/
protected function _construct()
{
parent::_construct();

$this->_map['fields']['store_title'] = 'store_table.name';
$this->_map['fields']['group_title'] = 'group_table.name';
$this->_map['fields']['name'] = 'main_table.name';
}

/**
* Join website and store names
*
Expand All @@ -21,4 +33,37 @@ protected function _initSelect()
$this->joinGroupAndStore();
return $this;
}

/**
* @inheritdoc
*/
public function load($printQuery = false, $logQuery = false)
{
if ($this->isLoaded()) {
return $this;
}

return $this->loadWithFilter($printQuery, $logQuery);
}

/**
* @inheritdoc
*/
public function joinGroupAndStore()
{
if (!$this->getFlag('groups_and_stores_joined')) {
$this->_idFieldName = 'website_group_store';
$this->getSelect()->joinLeft(
['group_table' => $this->getTable('store_group')],
'main_table.website_id = group_table.website_id',
['group_id' => 'group_id', 'group_title' => 'name', 'group_code' => 'code']
)->joinLeft(
['store_table' => $this->getTable('store')],
'group_table.group_id = store_table.group_id',
['store_id' => 'store_id', 'store_title' => 'name', 'store_code' => 'code']
);
}

return $this;
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
<fillField selector="{{AdminNewStoreGroupSection.storeGrpCodeTextField}}" userInput="{{storeGroupCode}}" stepKey="enterStoreGroupCode" />
<selectOption selector="{{AdminNewStoreGroupSection.storeRootCategoryDropdown}}" userInput="Default Category" stepKey="chooseRootCategory" />
<click selector="{{AdminStoreGroupActionsSection.saveButton}}" stepKey="clickSaveStoreGroup" />
<waitForElementVisible selector="{{AdminStoresGridSection.storeGrpFilterTextField}}" stepKey="waitForStoreGridReload"/>
<waitForElementVisible selector="{{AdminStoresGridFilterSection.filters}}" stepKey="waitForStoreGridReload"/>
<see userInput="You saved the store." stepKey="seeSavedMessage" />
</actionGroup>
</actionGroups>
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
<fillField selector="{{AdminNewWebsiteSection.name}}" userInput="{{newWebsiteName}}" stepKey="enterWebsiteName" />
<fillField selector="{{AdminNewWebsiteSection.code}}" userInput="{{websiteCode}}" stepKey="enterWebsiteCode" />
<click selector="{{AdminNewWebsiteActionsSection.saveWebsite}}" stepKey="clickSaveWebsite" />
<waitForElementVisible selector="{{AdminStoresGridSection.websiteFilterTextField}}" stepKey="waitForStoreGridToReload"/>
<waitForElementVisible selector="{{AdminStoresGridFilterSection.filters}}" stepKey="waitForStoreGridToReload"/>
<see userInput="You saved the website." stepKey="seeSavedMessage" />
</actionGroup>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,12 @@
</arguments>
<amOnPage url="{{AdminSystemStorePage.url}}" stepKey="navigateToStoresIndex"/>
<waitForPageLoad stepKey="waitStoreIndexPageLoad" />
<fillField selector="{{AdminStoresGridSection.storeFilterTextField}}" userInput="{{customStore.name}}" stepKey="fillStoreViewFilterField"/>
<click selector="{{AdminStoresGridSection.searchButton}}" stepKey="clickSearch"/>
<click selector="{{AdminStoresGridSection.storeNameInFirstRow}}" stepKey="clickStoreViewInGrid"/>
<conditionalClick selector="{{AdminStoresGridFilterSection.clearFilters}}" dependentSelector="{{AdminStoresGridFilterSection.clearFilters}}" visible="true" stepKey="clickClearFilters"/>
<click selector="{{AdminStoresGridFilterSection.filters}}" stepKey="openStoresFilters"/>
<fillField selector="{{AdminStoresGridFilterSection.storeViewFilter}}" userInput="{{customStore.name}}" stepKey="fillStoreViewFilterField"/>
<click selector="{{AdminStoresGridFilterSection.applyFilters}}" stepKey="clickApplyFilters"/>
<waitForLoadingMaskToDisappear stepKey="waitForGridLoad"/>
<click selector="{{AdminStoresGridSection.storeViewInFirstRow}}" stepKey="clickStoreViewInGrid"/>
<waitForPageLoad stepKey="waitForStoreViewPage"/>
<click selector="{{AdminNewStoreViewActionsSection.delete}}" stepKey="clickDeleteStoreView"/>
<selectOption selector="{{AdminStoreBackupOptionsSection.createBackupSelect}}" userInput="No" stepKey="dontCreateDbBackup"/>
Expand All @@ -29,6 +32,6 @@
<arguments>
<argument name="customStoreName" type="string"/>
</arguments>
<fillField selector="{{AdminStoresGridSection.storeFilterTextField}}" userInput="{{customStoreName}}" stepKey="fillStoreViewFilterField"/>
<fillField selector="{{AdminStoresGridFilterSection.storeViewFilter}}" userInput="{{customStoreName}}" stepKey="fillStoreViewFilterField"/>
</actionGroup>
</actionGroups>
Original file line number Diff line number Diff line change
Expand Up @@ -12,16 +12,18 @@
<argument name="websiteName" type="string"/>
</arguments>
<amOnPage url="{{AdminSystemStorePage.url}}" stepKey="amOnAdminSystemStorePage"/>
<click selector="{{AdminStoresGridSection.resetButton}}" stepKey="resetSearchFilter"/>
<fillField userInput="{{websiteName}}" selector="{{AdminStoresGridSection.websiteFilterTextField}}" stepKey="fillSearchWebsiteField"/>
<click selector="{{AdminStoresGridSection.searchButton}}" stepKey="clickSearchButton"/>
<see userInput="{{websiteName}}" selector="{{AdminStoresGridSection.websiteNameInFirstRow}}" stepKey="verifyThatCorrectWebsiteFound"/>
<click selector="{{AdminStoresGridSection.websiteNameInFirstRow}}" stepKey="clickEditExistingStoreRow"/>
<conditionalClick selector="{{AdminStoresGridFilterSection.clearFilters}}" dependentSelector="{{AdminStoresGridFilterSection.clearFilters}}" visible="true" stepKey="clickClearFilters"/>
<click selector="{{AdminStoresGridFilterSection.filters}}" stepKey="openStoresFilters"/>
<fillField selector="{{AdminStoresGridFilterSection.websiteFilter}}" userInput="{{websiteName}}" stepKey="fillWebsiteFilter"/>
<click selector="{{AdminStoresGridFilterSection.applyFilters}}" stepKey="clickApplyFilters"/>
<waitForLoadingMaskToDisappear stepKey="waitForGridLoad"/>
<see userInput="{{websiteName}}" selector="{{AdminStoresGridSection.websiteInFirstRow}}" stepKey="verifyThatCorrectWebsiteFound"/>
<click selector="{{AdminStoresGridSection.websiteInFirstRow}}" stepKey="clickEditExistingStoreRow"/>
<waitForPageLoad stepKey="waitForStoreToLoad"/>
<click selector="{{AdminStoresMainActionsSection.deleteButton}}" stepKey="clickDeleteWebsiteButtonOnEditWebsitePage"/>
<selectOption userInput="No" selector="{{AdminStoresDeleteStoreGroupSection.createDbBackup}}" stepKey="setCreateDbBackupToNo"/>
<click selector="{{AdminStoresDeleteStoreGroupSection.deleteStoreGroupButton}}" stepKey="clickDeleteWebsiteButton"/>
<waitForElementVisible selector="{{AdminStoresGridSection.websiteFilterTextField}}" stepKey="waitForStoreGridToReload"/>
<waitForElementVisible selector="{{AdminStoresGridFilterSection.filters}}" stepKey="waitForStoreGridToReload"/>
<see userInput="You deleted the website." stepKey="seeSavedMessage"/>
<conditionalClick selector="{{AdminDataGridHeaderSection.clearFilters}}" dependentSelector="{{AdminDataGridHeaderSection.clearFilters}}" visible="true" stepKey="clearExistingFilters"/>
</actionGroup>
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
<?xml version="1.0" encoding="UTF-8"?>
<!--
/**
* Copyright © Magento, Inc. All rights reserved.
* See COPYING.txt for license details.
*/
-->

<actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:noNamespaceSchemaLocation="../../../../../../../dev/tests/acceptance/vendor/magento/magento2-functional-testing-framework/src/Magento/FunctionalTestingFramework/Test/etc/actionGroupSchema.xsd">
<actionGroup name="filterStoresGridByWebsite">
<arguments>
<argument name="website" type="string"/>
</arguments>
<conditionalClick selector="{{AdminStoresGridFilterSection.clearFilters}}" dependentSelector="{{AdminStoresGridFilterSection.clearFilters}}" visible="true" stepKey="clickClearFilters"/>
<click selector="{{AdminStoresGridFilterSection.filters}}" stepKey="openStoresFilters"/>
<fillField selector="{{AdminStoresGridFilterSection.websiteFilter}}" userInput="{{website}}" stepKey="fillWebsiteFilter"/>
<click selector="{{AdminStoresGridFilterSection.applyFilters}}" stepKey="clickApplyFilters"/>
<waitForLoadingMaskToDisappear stepKey="waitForGridLoad"/>
</actionGroup>

<actionGroup name="filterStoresGridByStore">
<arguments>
<argument name="store" type="string"/>
</arguments>
<conditionalClick selector="{{AdminStoresGridFilterSection.clearFilters}}" dependentSelector="{{AdminStoresGridFilterSection.clearFilters}}" visible="true" stepKey="clickClearFilters"/>
<click selector="{{AdminStoresGridFilterSection.filters}}" stepKey="openStoresFilters"/>
<fillField selector="{{AdminStoresGridFilterSection.storeFilter}}" userInput="{{store}}" stepKey="fillStoreFilter"/>
<click selector="{{AdminStoresGridFilterSection.applyFilters}}" stepKey="clickApplyFilters"/>
<waitForLoadingMaskToDisappear stepKey="waitForGridLoad"/>
</actionGroup>

<actionGroup name="filterStoresGridByStoreView">
<arguments>
<argument name="storeView" type="string"/>
</arguments>
<conditionalClick selector="{{AdminStoresGridFilterSection.clearFilters}}" dependentSelector="{{AdminStoresGridFilterSection.clearFilters}}" visible="true" stepKey="clickClearFilters"/>
<click selector="{{AdminStoresGridFilterSection.filters}}" stepKey="openStoresFilters"/>
<fillField selector="{{AdminStoresGridFilterSection.storeViewFilter}}" userInput="{{storeView}}" stepKey="fillStoreViewFilter"/>
<click selector="{{AdminStoresGridFilterSection.applyFilters}}" stepKey="clickApplyFilters"/>
<waitForLoadingMaskToDisappear stepKey="waitForGridLoad"/>
</actionGroup>
</actionGroups>
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,12 @@
<argument name="storeGroupName" defaultValue="customStoreGroup.name"/>
</arguments>
<amOnPage stepKey="amOnAdminSystemStorePage" url="{{AdminSystemStorePage.url}}"/>
<click stepKey="resetSearchFilter" selector="{{AdminStoresGridSection.resetButton}}"/>
<fillField stepKey="fillSearchStoreGroupField" selector="{{AdminStoresGridSection.storeGrpFilterTextField}}" userInput="{{storeGroupName}}"/>
<click stepKey="clickSearchButton" selector="{{AdminStoresGridSection.searchButton}}"/>
<see stepKey="verifyThatCorrectStoreGroupFound" selector="{{AdminStoresGridSection.storeGrpNameInFirstRow}}" userInput="{{storeGroupName}}"/>
<click stepKey="clickEditExistingStoreRow" selector="{{AdminStoresGridSection.storeGrpNameInFirstRow}}"/>
<conditionalClick stepKey="resetSearchFilter" selector="{{AdminStoresGridFilterSection.clearAll}}" dependentSelector="{{AdminStoresGridFilterSection.clearAll}}" visible="true"/>
<click selector="{{AdminStoresGridFilterSection.filters}}" stepKey="openStoresFilters"/>
<fillField stepKey="fillSearchStoreGroupField" selector="{{AdminStoresGridFilterSection.storeFilter}}" userInput="{{storeGroupName}}"/>
<click stepKey="clickSearchButton" selector="{{AdminStoresGridFilterSection.applyFilters}}"/>
<see stepKey="verifyThatCorrectStoreGroupFound" selector="{{AdminStoresGridSection.storeInFirstRow}}" userInput="{{storeGroupName}}"/>
<click stepKey="clickEditExistingStoreRow" selector="{{AdminStoresGridSection.storeInFirstRow}}"/>
<waitForPageLoad stepKey="waitForStoreToLoad"/>
<click stepKey="clickDeleteStoreGroupButtonOnEditStorePage" selector="{{AdminStoresMainActionsSection.deleteButton}}"/>
<selectOption stepKey="setCreateDbBackupToNo" selector="{{AdminStoresDeleteStoreGroupSection.createDbBackup}}" userInput="No"/>
Expand Down
Loading