Skip to content

Extend default config instead overwrite #16001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2018
Merged

Extend default config instead overwrite #16001

merged 1 commit into from
Jun 13, 2018

Conversation

likemusic
Copy link
Contributor

Description

Default FormElementDependenceController config should be extended by custom config but not overridden.

Manual testing scenarios

  1. Add custom options to FormElementDependenceController config;
  2. Open System config page.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@VladimirZaets
Copy link
Contributor

Hi, @likemusic, I took your PR into processing, thank you for collaboration.

@magento-engcom-team
Copy link
Contributor

Hi @likemusic. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.2.6 release.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

@likemusic likemusic deleted the fix-config-overriding branch June 13, 2018 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants