Skip to content

[Forwardport] Make necessary space. #4 #15804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[Forwardport] Make necessary space. #4 #15804

wants to merge 1 commit into from

Conversation

chirag-wagento
Copy link
Contributor

Original Pull Request

#15790

Description

Make necessary space between media-common and css class .

Fixed Issues (if relevant)

N/A

Manual testing scenarios

N/A

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team magento-engcom-team added Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner labels Jun 5, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.0 milestone Jun 5, 2018
@sidolov
Copy link
Contributor

sidolov commented Jun 5, 2018

@chirag-wagento , please, combine this pull request with another to the same release line: #15798. It will be simpler to process and deliver your changes. Thank you!

@sidolov sidolov closed this Jun 5, 2018
@chirag-wagento
Copy link
Contributor Author

@sidolov

I can see my changes in 2.3-develop branch. How can I merge and push #15800, #15798 and #15804. can you please suggest me.

Thanks

@sidolov
Copy link
Contributor

sidolov commented Jun 12, 2018

Hi @chirag-wagento , it's simple:

@chirag-wagento
Copy link
Contributor Author

Hello @sidolov

I have already done above steps.

  1. I have checkout 2.3-develop-PR-port-15789
  2. Up to date with 2.3-develop branch.
  3. Merged 2.3-develop-PR-port-15790
  4. it's show me Already up to date.

Can you please check once what is issue branches.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Frontend Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner Release Line: 2.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants