Skip to content

Store Tracking URL in DB as well as Tracking Code #10854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 17 commits into from
Closed

Store Tracking URL in DB as well as Tracking Code #10854

wants to merge 17 commits into from

Conversation

RhodriOwainDavies
Copy link

Description

Add a new field sales_shipment_track.track_url.
Expose this field via API.
Including this URL as a hyperlink in the Shipment Sent Email template.

Feature

To support impending Magento Shipping feature request of inserting Carrier Specific URL in email template to Customer

Manual testing scenarios

  1. API Test
    POST /V1/order/{orderId}/ship
    Pass in tracking_url as an extension attribute (in same manner as tracking_number)
  2. UI Test
    In the admin section, view a Shipment which already has a trackinging URL set (via API in Test Can you commit to repository a folder dev/tests/static ? #1). Click Send Tracking Email. Check email, Tracking Number should be a hyperlink to tracking_url

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@orlangur
Copy link
Contributor

Please continue work in #10799 instead of making a new PR with the same changes.

It would be nice to squash all changes into a single commit and force push a MAGESHIP-21 branch. Please tell me if you need any assistance with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants