Coding standards: arrays

[tzyganu]

I've gone through the coding standards document (that by the ways it's very well wrtitten 😄 Thanks for this. ), but I didn't find anything regarding the array declaration format.
Since Magento 2 will support php 5.4+ we can use the clasic form $a = array(1,2,3) or the short form $a = [1,2,3]. I see in the code that both forms are used.

• Long format
• Short format.

I actually have 2 questions here:

• Is this going to be standardized? (I know it's not that easy)
• What format do you encourage developers to use? (or is "use them as you like them"?)

[antonmakarenko]

The document you mentioned is outdated. We are using a standard that complies with all requirements of PSR-2 and has some rules inherited from ZF coding standard. Although this document is not published yet.

In that standard, we have a provision:

1.7.1. Code written for PHP 5.4 and after, must use short array syntax
$array = ['foo' => 'bar'];

[tzyganu]

Good enough for me. Thanks

[magento-team]

Hi @tzyganu. Thank you for your report.
The issue has been fixed in magento-engcom/magento2ce#1193 by @nmalevanec in 2.3-develop branch
Related commit(s):

• 6d86db1

The fix will be available with the upcoming patch release.

[magento-engcom-team]

Hi @tzyganu. Thank you for your report.
The issue has been fixed in #14675 by @nmalevanec in 2.3-develop branch
Related commit(s):

• 8c023494d9ee2f4350a91f8d2139a31689cb4512

The fix will be available with the upcoming 2.3.0 release.