Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Developer Experience] PHPDoc and Typo #39376

Open
1 of 5 tasks
wubinworks opened this issue Nov 17, 2024 · 1 comment
Open
1 of 5 tasks

[Developer Experience] PHPDoc and Typo #39376

wubinworks opened this issue Nov 17, 2024 · 1 comment
Labels
Issue: ready for confirmation Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it

Comments

@wubinworks
Copy link

Summary

Confirmed on Magento 2.4.x

Issue 1:

PHPDoc

Issue 2:

Typo

See Examples.

Examples

Links are for Branch: 2.4.8-beta1

Issue 1:

\Magento\Framework\App\ScopeResolver#L13

/**
 * @var \Magento\Store\Model\StoreManagerInterface
 */
protected $objectManager;

should be

/**
 * @var ObjectManagerInterface
 */
protected $objectManager;

Issue 2:

\Magento\LoginAsCustomer\Model\GetLoggedAsCustomerAdminId#L38

return (int)$this->session->getLoggedAsCustomerAdmindId();
                                                    ^ extra d

\Magento\LoginAsCustomer\Model\SetLoggedAsCustomerAdminId#L38

$this->session->setLoggedAsCustomerAdmindId($adminId);
                                        ^ extra d

Proposed solution

See above.

Release note

No response

Triage and priority

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
@wubinworks wubinworks added the Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it label Nov 17, 2024
Copy link

m2-assistant bot commented Nov 17, 2024

Hi @wubinworks. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce.


Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: ready for confirmation Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it
Projects
Status: Ready for Confirmation
Development

No branches or pull requests

1 participant