bin/magento sampledata:deploy --no-update throws an exception

[JeroenBoersma]

Preconditions and environment

• Magento version 2.4.7-p3

Steps to reproduce

• Install a clean version of Magento
• In the console try to run bin/magento sampledata:deploy --no-update

Expected result

./composer.json has been updated                                                                                                                                                                                   
Sample data modules have been added via composer. Please run bin/magento setup:upgrade      

Actual result

$ bin/magento sampledata:deploy --no-update
                                                                                                         
In PackageDiscoveryTrait.php line 90:                                                                                                                                                                              
                                                                                                                                                                                                                  
  [TypeError]                                                                                                                                                                                                     
  Composer\Command\RequireCommand::determineRequirements(): Argument #6 ($useBestVersionConstraint) must be of type bool, int given, called in /project/vendor/composer/composer/src/Composer/Command/RequireCom  
  mand.php on line 213                                                                                                                                                                                            
                                                                                                                                                                                                                  

Exception trace:
  at /project/vendor/composer/composer/src/Composer/Command/PackageDiscoveryTrait.php:90
 Composer\Command\RequireCommand->determineRequirements() at /project/vendor/composer/composer/src/Composer/Command/RequireCommand.php:213
 Composer\Command\RequireCommand->execute() at /project/vendor/symfony/console/Command/Command.php:326
 Symfony\Component\Console\Command\Command->run() at /project/vendor/symfony/console/Application.php:1078
 Symfony\Component\Console\Application->doRunCommand() at /project/vendor/symfony/console/Application.php:324
 Symfony\Component\Console\Application->doRun() at /project/vendor/composer/composer/src/Composer/Console/Application.php:394
 Composer\Console\Application->doRun() at /project/vendor/symfony/console/Application.php:175
 Symfony\Component\Console\Application->run() at /project/vendor/composer/composer/src/Composer/Console/Application.php:148
 Composer\Console\Application->run() at /project/vendor/magento/module-sample-data/Console/Command/SampleDataDeployCommand.php:106
 Magento\SampleData\Console\Command\SampleDataDeployCommand->execute() at /project/vendor/symfony/console/Command/Command.php:326
 Symfony\Component\Console\Command\Command->run() at /project/vendor/symfony/console/Application.php:1078
 Symfony\Component\Console\Application->doRunCommand() at /project/vendor/symfony/console/Application.php:324
 Symfony\Component\Console\Application->doRun() at /project/vendor/magento/framework/Console/Cli.php:118
 Magento\Framework\Console\Cli->doRun() at /project/vendor/symfony/console/Application.php:175
 Symfony\Component\Console\Application->run() at /project/bin/magento:23

require [--dev] [--dry-run] [--prefer-source] [--prefer-dist] [--prefer-install PREFER-INSTALL] [--fixed] [--no-suggest] [--no-progress] [--no-update] [--no-install] [--no-audit] [--audit-format AUDIT-FORMAT] [-
-update-no-dev] [-w|--update-with-dependencies] [-W|--update-with-all-dependencies] [--with-dependencies] [--with-all-dependencies] [--ignore-platform-req IGNORE-PLATFORM-REQ] [--ignore-platform-reqs] [--prefer-
stable] [--prefer-lowest] [-m|--minimal-changes] [--sort-packages] [-o|--optimize-autoloader] [-a|--classmap-authoritative] [--apcu-autoloader] [--apcu-autoloader-prefix APCU-AUTOLOADER-PREFIX] [--] [<packages>.
..]                                                 

There is an error during sample data deployment. Composer file will be reverted.

Additional information

vendor/magento/module-sample-data/Console/Command/SampleDataDeployCommand.php:93

-$commonArgs['--no-update'] =1;
+$commonArgs['--no-update'] = true;

Release note

When using --no-update in the sampledata:deploy command an error was thrown because since newer PHP versions the argument must be a boolean, a int was given.

Triage and priority

• Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant]

Hi @JeroenBoersma. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce.

• For more details, review the Magento Contributor Assistant documentation.
• Add a comment to assign the issue: @magento I am working on this
• To learn more about issue processing workflow, refer to the Code Contributions.

---

Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

[JeroenBoersma]

Crafting an MR!

[JeroenBoersma]

@magento I am working on this

[m2-assistant]

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
• 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
• 4. Verify that the issue is reproducible on 2.4-develop branch
  Details

  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
• 5. Add label Issue: Confirmed once verification is complete.
• 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-Bravo]

Hi @JeroenBoersma,

Thanks for your reporting and collaboration.

We have verified the issue in Latest Magento instance and the issue is reproducible.Kindly refer the screenshots.

Steps to reproduce

• Install a clean version of Magento
• In the console try to run bin/magento sampledata:deploy --no-update

Hence Confirming the issue.

Thanks.

[github-jira-sync-bot]

✅ Jira issue https://jira.corp.adobe.com/browse/AC-13324 is successfully created for this GitHub issue.

[m2-assistant]

✅ Confirmed by @engcom-Bravo. Thank you for verifying the issue.
Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.