Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue] Feature/php8.1 constructor property promotion wee graph ql #39309

Open
5 tasks done
m2-assistant bot opened this issue Oct 29, 2024 · 2 comments · May be fixed by #36975
Open
5 tasks done

[Issue] Feature/php8.1 constructor property promotion wee graph ql #39309

m2-assistant bot opened this issue Oct 29, 2024 · 2 comments · May be fixed by #36975
Assignees
Labels
Area: Tax Component: Tax Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: PR in progress Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@m2-assistant
Copy link

m2-assistant bot commented Oct 29, 2024

This issue is automatically created based on existing pull request: #36975: Feature/php8.1 constructor property promotion wee graph ql


Description (*)

Replace allmost all properties with constructor property promotion in module wee graph ql:
https://stitcher.io/blog/constructor-promotion-in-php-8

  • Readable code
  • Make Magento less complex by removing properties which take up a lot of lines.
  • Imported all classes to make code more readable.
    I think the code would be a lot cleaner if all modules start using constructor promotions, since of 2.4.6 php 7.4 is dropped we can now make use of it. So let's start on it right now :).

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)
@m2-assistant m2-assistant bot added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Oct 29, 2024
@m2-assistant m2-assistant bot linked a pull request Oct 29, 2024 that will close this issue
6 tasks
@engcom-Dash engcom-Dash added Component: Tax Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Area: Tax labels Oct 29, 2024
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.adobe.com/browse/AC-13295 is successfully created for this GitHub issue.

Copy link
Author

m2-assistant bot commented Oct 29, 2024

✅ Confirmed by @engcom-Dash. Thank you for verifying the issue.
Issue Available: @engcom-Dash, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Tax Component: Tax Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: PR in progress Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants