Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magento 2.4.7 minAllowed missing product order qty #39142

Open
1 of 5 tasks
Jilco opened this issue Sep 4, 2024 · 17 comments
Open
1 of 5 tasks

Magento 2.4.7 minAllowed missing product order qty #39142

Jilco opened this issue Sep 4, 2024 · 17 comments
Labels
Area: Product Component: Catalog Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P3 May be fixed according to the position in the backlog. Progress: ready for dev Reported on 2.4.7-p2 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@Jilco
Copy link

Jilco commented Sep 4, 2024

Preconditions and environment

  • Magento version 2.4.7-P2
  • See source code product page

Steps to reproduce

  1. View product (on product page)
  2. View Source
  3. Search (CTRL + F) maxAllowed

Expected result

input type="number" name="qty" id="qty" maxlength="12" value="0.5" title="Aantal" class="input-text qty" data-validate="{"required-number":true,"validate-item-quantity":{"minAllowed":0.5,"maxAllowed":10000}}" /

Actual result

input type="number" name="qty" id="qty" min="0" value="0.6" title="Aantal" class="input-text qty" data-validate="{"required-number":true,"validate-item-quantity":{"maxAllowed":999}}" /

Additional information

min="0" is present, but not correct (min order qty is 0.6 for this product)

Release note

No response

Triage and priority

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
Copy link

m2-assistant bot commented Sep 4, 2024

Hi @Jilco. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:


Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

@Jilco
Copy link
Author

Jilco commented Sep 4, 2024

@magento give me 2.4-develop instance

Copy link

Hi @Jilco. Thank you for your request. I'm working on Magento instance for you.

Copy link

@Jilco
Copy link
Author

Jilco commented Sep 4, 2024

input type="number"

  | name="qty"
  | id="qty"
  | min="0"
  | value="1"
  | title="Qty"
  | class="input-text qty"
  | data-validate="{"required-number":true,"validate-item-quantity":{"maxAllowed":10000}}"
  |

@engcom-Bravo engcom-Bravo self-assigned this Sep 5, 2024
Copy link

m2-assistant bot commented Sep 5, 2024

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
  • 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
  • 4. Verify that the issue is reproducible on 2.4-develop branch
    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
  • 5. Add label Issue: Confirmed once verification is complete.
  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Bravo engcom-Bravo added the Reported on 2.4.7-p2 Indicates original Magento version for the Issue report. label Sep 5, 2024
@engcom-Bravo
Copy link
Contributor

@magento give me 2.4-develop instance

Copy link

Hi @engcom-Bravo. Thank you for your request. I'm working on Magento instance for you.

Copy link

@engcom-Bravo
Copy link
Contributor

Hi @Jilco,

Thanks for your reporting and collaboration.

We have verified the issue in Latest 2.4-develop instance and the issue is reproducible.Kindly refer the screenshots.

Screenshot 2024-09-05 at 10 33 36 Screenshot 2024-09-05 at 10 28 30

The min qty is still 0.

Hence confirming the issue.

Thanks.

@engcom-Bravo engcom-Bravo added Component: Catalog Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Priority: P3 May be fixed according to the position in the backlog. Area: Product labels Sep 5, 2024
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.adobe.com/browse/AC-12909 is successfully created for this GitHub issue.

Copy link

m2-assistant bot commented Sep 5, 2024

✅ Confirmed by @engcom-Bravo. Thank you for verifying the issue.
Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@chrom
Copy link
Contributor

chrom commented Sep 16, 2024

@magento give me 2.4-develop instance

Copy link

Hi @chrom. Thank you for your request. I'm working on Magento instance for you.

Copy link

Hi @chrom, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

@Jilco
Copy link
Author

Jilco commented Oct 1, 2024

Anny updates?

@Jilco
Copy link
Author

Jilco commented Oct 4, 2024

I discoverd it is in vendor/magento/module-catalog-inventory/Block/Plugin/Productview.php

The minsales parameter was missing there, so i added it and problem was solved

public function afterGetQuantityValidators(
\Magento\Catalog\Block\Product\View $block,
array $validators
) {
$stockItem = $this->stockRegistry->getStockItem(
$block->getProduct()->getId(),
$block->getProduct()->getStore()->getWebsiteId()
);

    $params = [];
    if ($stockItem->getMaxSaleQty()) {
        $params['maxAllowed'] = (float)$stockItem->getMaxSaleQty();
    }
    
    if ($stockItem->getMinSaleQty()) {
        $params['minAllowed'] = (float)$stockItem->getMinSaleQty();
    }
    
    if ($stockItem->getQtyIncrements() > 0) {
        $params['qtyIncrements'] = (float)$stockItem->getQtyIncrements();
    }
    $validators['validate-item-quantity'] = $params;

    return $validators;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Product Component: Catalog Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P3 May be fixed according to the position in the backlog. Progress: ready for dev Reported on 2.4.7-p2 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
None yet
Development

No branches or pull requests

4 participants