Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle Product with dynamic price - partial refund - incorrect quantity for the parent product #39060

Open
1 of 5 tasks
gorbunovav opened this issue Aug 17, 2024 · 7 comments
Open
1 of 5 tasks
Labels
Area: Order Component: order status Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P3 May be fixed according to the position in the backlog. Progress: ready for dev Reported on 2.4.7 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@gorbunovav
Copy link

Preconditions and environment

  • Magento version: 2.4.7

Steps to reproduce

  1. Create Bundle Product, set price to "dynamic", add some optional bundle items
  2. Place an order with this bundle product and some bundle items selected, set quantity to 2
  3. Invoice it
  4. Try to create a credit memo - notice that it is not possible to specify the quantity to refund for the bundle product itself. Set qty = 1 to some bundle items, and 0 all others.
  5. Save credit memo.
  6. Check in the sales_order_item table that qty_refunded for the root order item representing the bundle product is set to2 now, which doesn't make sense.

Expected result

Credit Memo allows to specify the quantity of Bundle Products to refund.
If Credit Memo refunds bundle items only without the parent product - it is still displayed correctly.

Actual result

Credit Memo doesn't allow to specify the quantity of Bundle Product to refund and automatically refunds full quantity (which can break some logic and reporting). If you manage to create a Credit Memo with Bundle Product quantity set to zero it will not display refunded bundle items (the list of refunded items will be empty).

Additional information

Ideally the quantity of child items (bundle items) in the order should represent the quantity per bundle, while the the quantity of the parent product - the number of bundles (like it is implemented for the cart).

With the current approach it is hard to tell what is the relation between the quantity of each bundle item refunded and the quantity of bundles to refund.

I think it is better to allow users to specify the quantity of Bundle Products to refund according to their own business logic requirements.

Release note

No response

Triage and priority

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
Copy link

m2-assistant bot commented Aug 17, 2024

Hi @gorbunovav. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:


Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

@engcom-Bravo engcom-Bravo added the Reported on 2.4.7 Indicates original Magento version for the Issue report. label Aug 19, 2024
@engcom-Bravo engcom-Bravo self-assigned this Aug 19, 2024
Copy link

m2-assistant bot commented Aug 19, 2024

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
  • 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
  • 4. Verify that the issue is reproducible on 2.4-develop branch
    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
  • 5. Add label Issue: Confirmed once verification is complete.
  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Bravo
Copy link
Contributor

Hi @gorbunovav,

Thanks for your reporting and collaboration.

We have verified the issue in Latest 2.4-develop instance and the issue is not reproducible.Kindly refer the screenshots.

Screenshot 2024-08-27 at 13 08 46 Screenshot 2024-08-27 at 13 18 19

Credit Memo allows to specify the quantity of Bundle Products to refund and also it displays correctly the qty_refunded.

Kindly recheck the issue in Latest 2.4-develop instance and elaborate the steps to reproduce if the issue is still reproducible.

Thanks.

@engcom-Bravo engcom-Bravo added the Issue: needs update Additional information is require, waiting for response label Aug 27, 2024
@engcom-Bravo engcom-Bravo moved this from Ready for Confirmation to Needs Update in Issue Confirmation and Triage Board Aug 27, 2024
@gorbunovav
Copy link
Author

gorbunovav commented Aug 29, 2024

@engcom-Bravo Hi!

Sorry, but I think you have missed some points in the ticket description.

You are showing that it is possible to refund child products inside the bundle.

And this ticket is about the parent product or the root Bundle product.
On your screenshot there is no field to specify the quantity for refund for the parent product.
And after saving the credit memo you can check the database - the refunded quantity for the bundle product line will be equal to the invoiced quantity.

Screenshot 2024-08-29 210604

@engcom-Bravo
Copy link
Contributor

Hi @gorbunovav,

Thanks for your update.

We have verified the issue in Latest 2.4-develop instance and the issue is reproducible.Kindly refer the screenshots.

Screenshot 2024-08-30 at 11 27 36

In Database we have the refunded quantity for the bundle product line will be equal to the invoiced quantity.in backend there is no field specified.

Hence Confirming the issue.

Thanks.

@engcom-Bravo engcom-Bravo removed the Issue: needs update Additional information is require, waiting for response label Aug 30, 2024
@engcom-Bravo engcom-Bravo added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Priority: P3 May be fixed according to the position in the backlog. Component: order status Area: Order labels Aug 30, 2024
@engcom-Bravo engcom-Bravo moved this from Needs Update to Confirmed in Issue Confirmation and Triage Board Aug 30, 2024
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.adobe.com/browse/AC-12867 is successfully created for this GitHub issue.

Copy link

m2-assistant bot commented Aug 30, 2024

✅ Confirmed by @engcom-Bravo. Thank you for verifying the issue.
Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Order Component: order status Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P3 May be fixed according to the position in the backlog. Progress: ready for dev Reported on 2.4.7 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
None yet
Development

No branches or pull requests

3 participants