Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplication of bundle product removes bundle selection from original product #38990

Open
1 of 5 tasks
jcnme opened this issue Jul 30, 2024 · 10 comments
Open
1 of 5 tasks
Labels
Area: Product Component: Bundle Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: ready for dev Reported on 2.4.7-p1 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@jcnme
Copy link

jcnme commented Jul 30, 2024

Preconditions and environment

  • Magento versions 2.4.7, 2.4.7-p1
  • Php version 8.1.27

Steps to reproduce

  1. Create simple product
  2. Create bundle product
  3. Add option to bundle product
  4. Add simple product to option
  5. Save bundle product
  6. Save and duplicate bundle product

Expected result

Both the original and duplicated bundle products should contain the simple product as a selection to bundle option.

Actual result

Only the duplicated bundle product contains the simple product as as a selection to bundle option. The original bundle product's bundle option selection is removed.

Additional information

No response

Release note

No response

Triage and priority

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
Copy link

m2-assistant bot commented Jul 30, 2024

Hi @jcnme. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:


Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

@jcnme
Copy link
Author

jcnme commented Jul 30, 2024

@magento give me 2.4-develop instance

Copy link

Hi @jcnme. Thank you for your request. I'm working on Magento instance for you.

@engcom-Bravo engcom-Bravo self-assigned this Jul 30, 2024
Copy link

m2-assistant bot commented Jul 30, 2024

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
  • 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
  • 4. Verify that the issue is reproducible on 2.4-develop branch
    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
  • 5. Add label Issue: Confirmed once verification is complete.
  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Bravo engcom-Bravo added the Reported on 2.4.7-p1 Indicates original Magento version for the Issue report. label Jul 30, 2024
Copy link

@jcnme
Copy link
Author

jcnme commented Jul 30, 2024

image
image

@engcom-Bravo
Copy link
Contributor

Hi @jcnme,

Thanks for your reporting and collaboration.

We have verified the issue in Latest 2.4-develop instance and the issue is reproducible.Kindly refer the screenshots.

Steps to reproduce

  • Create simple product
  • Create bundle product
  • Add option to bundle product
  • Add simple product to option
  • Save bundle product
  • Save and duplicate bundle product
Screenshot 2024-07-31 at 09 35 25 Screenshot 2024-07-31 at 09 36 02

Only the duplicated bundle product contains the simple product as as a selection to bundle option. The original bundle product's bundle option selection is removed.

Hence Confirming the issue.

Thanks.

@engcom-Bravo engcom-Bravo added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Component: Bundle Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Area: Product labels Jul 31, 2024
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.adobe.com/browse/AC-12648 is successfully created for this GitHub issue.

Copy link

m2-assistant bot commented Jul 31, 2024

✅ Confirmed by @engcom-Bravo. Thank you for verifying the issue.
Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@Nuranto
Copy link
Contributor

Nuranto commented Aug 12, 2024

Hello,

Here's a quick fix :

            "magento/module-bundle": {
                "Duplication bundle issue - https://github.com/magento/magento2/issues/38990": "patches/composer/magento/bundle/issue-38990.patch"
            },

--- a/Model/LinkManagement.php	2024-04-03 16:20:20
+++ b/Model/LinkManagement.php	2024-08-12 09:48:10
@@ -244,6 +244,9 @@
         );
 
         $selectionModel->setOptionId($optionId);
+        if ($product->getIsDuplicate()) {
+            $selectionModel->setSelectionId(null);
+        }
 
         try {
             $selectionModel->save();

@engcom-Hotel engcom-Hotel moved this to Ready for Development in High Priority Backlog Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Product Component: Bundle Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: ready for dev Reported on 2.4.7-p1 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
Status: Ready for Development
Development

No branches or pull requests

5 participants
@Nuranto @engcom-Bravo @github-jira-sync-bot @jcnme and others