Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Product custom option of type 'Drop-down' retains values in the database after being changed to type 'Field' #38450

Open
1 of 5 tasks
ksenia-zlotin opened this issue Feb 16, 2024 · 11 comments
Labels
Area: Catalog Component: Catalog Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: ready for dev Reported on 2.4.4-p6 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@ksenia-zlotin
Copy link

Preconditions and environment

2.4.4-p6

Steps to reproduce

  1. Create a product with a dropdown custom option and 1 value, save the product
  2. Change the existing custom option type to 'Field' and save the product
  3. View the database - old values are retained

Expected result

There is no reason to retain the option's values after saving

Actual result

Values are retained and if the custom option is never used as a dropdown again- are just cluttering the database

Additional information

No response

Release note

No response

Triage and priority

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
Copy link

m2-assistant bot commented Feb 16, 2024

Hi @ksenia-zlotin. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:


Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

Copy link

m2-assistant bot commented Feb 19, 2024

Hi @engcom-Dash. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

    1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
    1. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
    1. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
    1. Verify that the issue is reproducible on 2.4-develop branch
      Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
      - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
      - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

@engcom-Dash engcom-Dash removed their assignment Feb 19, 2024
@engcom-November engcom-November self-assigned this Feb 19, 2024
Copy link

m2-assistant bot commented Feb 19, 2024

Hi @engcom-November. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
  • 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
  • 4. Verify that the issue is reproducible on 2.4-develop branch
    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
  • 5. Add label Issue: Confirmed once verification is complete.
  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-November
Copy link
Contributor

Hello @ksenia-zlotin,

Thank you for the report and collaboration!

Do you mean the options are still present in eav_attribute_option_value table after changing the type of the custom attribute?
Can you please let us know where the value is being retained.

Thank you.

@engcom-November engcom-November added Issue: needs update Additional information is require, waiting for response Reported on 2.4.4-p6 Indicates original Magento version for the Issue report. labels Feb 19, 2024
@ksenia-zlotin
Copy link
Author

When a product custom option (not to be confused with attribute) which used to be a dropdown type with values stored in the table catalog_product_option_type_value gets changed to a field type, the values in the aforementioned table remain.

@NetStorm84
Copy link
Contributor

@magento give me 2.4-develop instance

Copy link

Hi @NetStorm84. Thank you for your request. I'm working on Magento instance for you.

Copy link

@engcom-November
Copy link
Contributor

Hello @ksenia-zlotin,

Thank you for the quick response!

Verified this issue on 2.4-develop.
The product with a customizable Option which was a dropdown with option value 1, when changed to type field, the product retained the old option value.

Please take a look at the screenshot below:
Here we have changed the dropdown to type field
image

But the old option value is still retained
image

Hence confirming the issue.

Thank you.

@engcom-November engcom-November added Component: Catalog Area: Catalog Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Feb 21, 2024
@m2-community-project m2-community-project bot removed the Issue: needs update Additional information is require, waiting for response label Feb 21, 2024
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.adobe.com/browse/AC-11387 is successfully created for this GitHub issue.

Copy link

m2-assistant bot commented Feb 21, 2024

✅ Confirmed by @engcom-November. Thank you for verifying the issue.
Issue Available: @engcom-November, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@engcom-November engcom-November added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Catalog Component: Catalog Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: ready for dev Reported on 2.4.4-p6 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
Status: Ready for Development
Development

No branches or pull requests

5 participants