Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website restriction -> Private Sale: Login only, preventing registration on API as Admin #38008

Open
1 of 5 tasks
ghezelbash opened this issue Sep 25, 2023 · 5 comments
Open
1 of 5 tasks
Labels
Area: APIs Component: Customer Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: ready for dev Reported on 2.4.5-p2 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@ghezelbash
Copy link

Preconditions and environment

  • Magento version: 2.4.5-p2 commerce
  • Go to Stores > Configuration > General > General > Website Restrictions, set Access Restriction (general/restriction/is_active) to 'Yes' and set Restriction Mode (general/restriction/mode) to Private Sale: Login Only
  • Create an admin integration token

Steps to reproduce

  1. Go to Stores > Configuration > General > General > Website Restrictions
  2. Set Access Restriction (general/restriction/is_active) to 'Yes' and set Restriction Mode (general/restriction/mode) to Private Sale: Login Only
  3. Clear the config cache
  4. Create an admin integration token from System > Integrations
  5. Send a REST api POST request to /rest/V1/customers to create a customer and include admin integration token as Bearer token as Autorization

Expected result

Since admins can create custumers in Admin area when website restrictions is on, then they should have the ability to create customers via API.
Expected: Customer created. (Registration working when the requester is an admin user)

Actual result

API raises a 400 bad request response saying: "Can not register new customer due to restrictions are enabled."

Additional information

No response

Release note

No response

Triage and priority

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
@m2-assistant
Copy link

m2-assistant bot commented Sep 25, 2023

Hi @ghezelbash. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:


Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

@m2-assistant
Copy link

m2-assistant bot commented Sep 25, 2023

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
  • 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
  • 4. Verify that the issue is reproducible on 2.4-develop branch
    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
  • 5. Add label Issue: Confirmed once verification is complete.
  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Bravo engcom-Bravo added the Reported on 2.4.5-p2 Indicates original Magento version for the Issue report. label Sep 25, 2023
@engcom-Bravo
Copy link
Contributor

Hi @ghezelbash,

Thank you for reporting and collaboration.

Verified the issue on Magento 2.4-develop instance with EE edition and the issue is reproducible.Kindly refer the screenshots.

Steps to reproduce

  • Go to Stores > Configuration > General > General > Website Restrictions
  • Set Access Restriction (general/restriction/is_active) to 'Yes' and set Restriction Mode (general/restriction/mode) to Private Sale: Login Only
  • Clear the config cache
  • Create an admin integration token from System > Integrations
  • Send a REST api POST request to /rest/V1/customers to create a customer and include admin integration token as Bearer token as Autorization
Screenshot 2023-09-27 at 11 50 22 AM

We are not able to customer using REST API's but we are able to create the customer form the admin side .

Hence Confirming the issue.

Thanks.

@engcom-Bravo engcom-Bravo added Area: APIs Component: Customer Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. labels Sep 27, 2023
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.adobe.com/browse/AC-9613 is successfully created for this GitHub issue.

@m2-assistant
Copy link

m2-assistant bot commented Sep 27, 2023

✅ Confirmed by @engcom-Bravo. Thank you for verifying the issue.
Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: APIs Component: Customer Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: ready for dev Reported on 2.4.5-p2 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
Status: Ready for Development
Development

No branches or pull requests

3 participants