Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Venia Sample Data error with php 8.2 #37740

Open
5 tasks
ximenez opened this issue Jul 9, 2023 · 8 comments
Open
5 tasks

Venia Sample Data error with php 8.2 #37740

ximenez opened this issue Jul 9, 2023 · 8 comments
Labels
Adobe Commerce The issue related to the Adobe Commerce(EE) or B2B functionality Area: Admin UI Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: ready for dev Reported on 2.4.6-p1 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@ximenez
Copy link

ximenez commented Jul 9, 2023

Preconditions and environment

  • Magento version: Adobe Commerce 2.4.6-p1
  • Install Venia Sample Data "composer require magento/venia-sample-data:*"
  • bin/magento setup:upgrade

Steps to reproduce

  1. Adobe Commerce 2.4.6-p1 with PHP 8.2
  2. Install Venia Sample Data "composer require magento/venia-sample-data:*"
  3. Deployment error in cloud: Deprecated Functionality: Creation of dynamic property Magento\CmsSampleDataVenia\Model\Block\Converter::$eavConfig is deprecated in /app/vendor/magento/module-cms-sample-data-venia/Model/Block/Converter.php on line 66

Expected result

Venia Sample DAta works with PHP 8.2.

Actual result

Error:
Deprecated Functionality: Creation of dynamic property Magento\CmsSampleDataVenia\Model\Block\Converter::$eavConfig is deprecated in /app/vendor/magento/module-cms-sample-data-venia/Model/Block/Converter.php on line 66

Additional information

Fis should add $eavConfig property to block

/**
 * @var \Magento\Eav\Model\Config
 */
protected $eavConfig;

Release note

No response

Triage and priority

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
@m2-assistant
Copy link

m2-assistant bot commented Jul 9, 2023

Hi @ximenez. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:


Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

@m2-assistant
Copy link

m2-assistant bot commented Jul 9, 2023

Hi @engcom-Dash. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

    1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
    1. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
    1. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
    1. Verify that the issue is reproducible on 2.4-develop branch
      Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
      - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
      - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

@engcom-Dash engcom-Dash added the Reported on 2.4.6-p1 Indicates original Magento version for the Issue report. label Jul 9, 2023
@engcom-Dash
Copy link
Contributor

engcom-Dash commented Jul 11, 2023

Hi @ximenez ,

Verified the issue in 2.4-develop instance and the issue is not reproducible.
Steps to reproduce:
1.Install magento instance
2.Deploy sample data for composer instllation as per DevDocs
3.Run setup upgrade command
Kindly refer the below screenshots:
Screenshot 2023-07-11 at 11 20 51 AM
Screenshot 2023-07-11 at 11 21 05 AM
Screenshot 2023-07-11 at 11 23 04 AM
Screenshot 2023-07-11 at 11 28 14 AM

Sample data installed successfully

Thanks

@engcom-Dash engcom-Dash added the Issue: needs update Additional information is require, waiting for response label Jul 11, 2023
@ximenez
Copy link
Author

ximenez commented Jul 12, 2023

@engcom-Dash
Issue is with "Venia Sample Data", not with Standard Sample Data.

@engcom-Dash engcom-Dash added the Adobe Commerce The issue related to the Adobe Commerce(EE) or B2B functionality label Jul 13, 2023
@engcom-Dash
Copy link
Contributor

Hi @ximenez ,

Verified the issue in 2.4.6-p1 adobe commerce and the issue is reproducible,Hence we are confirming the issue.
Kindly refer the below screenshot:
Screenshot 2023-07-19 at 7 24 46 PM

Thanks.

@engcom-Dash engcom-Dash removed the Issue: needs update Additional information is require, waiting for response label Jul 19, 2023
@engcom-Dash engcom-Dash added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Area: Admin UI and removed Issue: ready for confirmation labels Jul 19, 2023
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.adobe.com/browse/AC-9163 is successfully created for this GitHub issue.

@m2-assistant
Copy link

m2-assistant bot commented Jul 19, 2023

✅ Confirmed by @engcom-Dash. Thank you for verifying the issue.
Issue Available: @engcom-Dash, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@hostep
Copy link
Contributor

hostep commented Jul 19, 2023

Is possibly already fixed by PMET-public/module-venia-cms-sample-data@471542c, but no idea if that is the official module on github, or just some clone, also no idea if a new version was created containing this fix (the commit mentions version 0.0.4, but no idea if it's published yet on repo.magento.com)

Just FYI...

@engcom-Bravo engcom-Bravo added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Jul 20, 2023
@engcom-Hotel engcom-Hotel moved this to Ready for Development in High Priority Backlog Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Adobe Commerce The issue related to the Adobe Commerce(EE) or B2B functionality Area: Admin UI Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: ready for dev Reported on 2.4.6-p1 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
Status: Ready for Development
Development

No branches or pull requests

5 participants