Custom Price of 0 gets reset to original price on reorder.

[Hexmage]

Preconditions and environment

• Any, apparently been a bug since 2.0

Steps to reproduce

Create an order in admin panel.
Set custom price to 0 for one product.
Place the order.
Reorder the same order.

Expected result

Expect the changed product to have a custom price of 0.

Actual result

The changed product has its original price.

Additional information

magento2/app/code/Magento/Quote/Model/Quote/Item/Processor.php

Line 104 in 4a41ec4

if (!empty($customPrice) && !$candidate->getParentProductId()) {

When custom price is 0 the empty() validates as true. While it should validate as false, because 0 is a valid price.

Release note

No response

Triage and priority

• Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant]

Hi @Hexmage. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

• @magento give me 2.4-develop instance - upcoming 2.4.x release
• For more details, review the Magento Contributor Assistant documentation.
• Add a comment to assign the issue: @magento I am working on this
• To learn more about issue processing workflow, refer to the Code Contributions.

---

Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

[m2-assistant]

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
• 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
• 4. Verify that the issue is reproducible on 2.4-develop branch
  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
• 5. Add label Issue: Confirmed once verification is complete.
• 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-Bravo]

@magento give me 2.4-develop instance

[magento-deployment-service]

Hi @engcom-Bravo. Thank you for your request. I'm working on Magento instance for you.

[magento-deployment-service]

Hi @engcom-Bravo, here is your Magento Instance: https://dcd9df82480834a60d4a7d8d2c55a00f.instances.magento-community.engineering
Admin access: https://dcd9df82480834a60d4a7d8d2c55a00f.instances.magento-community.engineering/admin_1b81
Login: e4684577
Password: 9b335d8de5f7

[engcom-Bravo]

Hi @Hexmage,

Thank you for reporting and collaboration.
Verified the issue on Magento 2.4-develop instance and the issue is not reproducible.Kindly refer the screenshots.

Steps to reproduce

• Create an order in admin panel.
• Set custom price to 0 for one product.
• Place the order.
• Reorder the same order.

We have changed the one of the custom price of the product to 0.We are able to the Reorder the product with original price.

Kindly recheck the behavior on Magento 2.4-develop instance and elaborate steps to reproduce if the issue is still reproducible.

Thanks.

[Hexmage]

@engcom-Bravo
I've just reproduced it.
Creating the Order:

When reordering that order:

[Hexmage]

If you reorder 000000010 on that instance you'll see it in action.