Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magento 2.4.5-p1 Repository save not working #36740

Open
smitakagwade opened this issue Jan 13, 2023 · 8 comments
Open

Magento 2.4.5-p1 Repository save not working #36740

smitakagwade opened this issue Jan 13, 2023 · 8 comments
Labels
Area: Framework Component: Catalog Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: ready for dev Reported on 2.4.5-p1 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it

Comments

@smitakagwade
Copy link

smitakagwade commented Jan 13, 2023

Preconditions (*)

  1. Magento version 2.4.5-p1
  2. Php 8.1

Steps to reproduce (*)

  1. try below code to set name to the category

  2. $category = $this->categoryRepository->get(4); $category->setName("Test"); $this->categoryRepository->save($category);

  3. I am trying to save category using this way ,

  4. But after click on save, page becomes unresponsive and Magento stops working

Expected result (*)

  1. Category Should be saved properly with repository save method

Actual result (*)

  1. Page becomes unresponsive and just showing loader on page

image

Custom Module that helps in issue reproduction

Magz.zip

@m2-assistant
Copy link

m2-assistant bot commented Jan 13, 2023

Hi @smitakagwade. Thank you for your report.
To speed up processing of this issue, make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, review the Magento Contributor Assistant documentation.

Add a comment to assign the issue: @magento I am working on this

To learn more about issue processing workflow, refer to the Code Contributions.


⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@m2-assistant
Copy link

m2-assistant bot commented Jan 13, 2023

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Bravo engcom-Bravo added the Reported on 2.4.5-p1 Indicates original Magento version for the Issue report. label Jan 13, 2023
@engcom-Bravo
Copy link
Contributor

Hi @smitakagwade,

Thank you for reporting and collaboration.

Verified the issue on Magento 2.4-develop instance and the issue is not reproducible. Kindly refer the screenhsots.

Steps to reproduce

1.try below code to set name to the category

2.$category = $this->categoryRepository->get(4); $category->setName("Test"); $this->categoryRepository->save($category);

We are able to save the category name without any error.

Screenshot 2023-01-13 at 1 51 20 PM

Kindly recheck the behavior on Magento 2.4-develop instance and elaborate steps to reproduce if the issue is still reproducible.

Thanks.

@engcom-Bravo engcom-Bravo added the Issue: needs update Additional information is require, waiting for response label Jan 13, 2023
@smitakagwade
Copy link
Author

Hello @engcom-Bravo,
I want to save this programmatically, not from frontend .
Repository save function is not working for category .

I want to save categories custom attribute values as well as default attributes using category repository.

I have written this code on catalog_category_save_after observer.

@engcom-Hotel engcom-Hotel added the Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it label Feb 3, 2023
@engcom-Hotel engcom-Hotel self-assigned this Feb 3, 2023
@m2-assistant
Copy link

m2-assistant bot commented Feb 3, 2023

Hi @engcom-Hotel. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.

  • 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Hotel
Copy link
Contributor

Hello @smitakagwade,

Thanks for the reporting and collaboration!

We have tried to reproduce the issue in Magento 2.4-develop and the issue is reproducible for us. The page was unresponsive and after sometime we are getting the below page:

image

In order to reproduce the issue, we have made the custom module. We are attaching the same for reference:
Magz.zip

Hence confirming the issue.

Thanks

@engcom-Hotel engcom-Hotel added Component: Catalog Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Area: Framework labels Feb 6, 2023
@engcom-Hotel engcom-Hotel removed Progress: dev in progress Issue: needs update Additional information is require, waiting for response labels Feb 6, 2023
@engcom-Hotel engcom-Hotel added the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Feb 7, 2023
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.adobe.com/browse/AC-7891 is successfully created for this GitHub issue.

@m2-assistant
Copy link

m2-assistant bot commented Feb 7, 2023

✅ Confirmed by @engcom-Hotel. Thank you for verifying the issue.
Issue Available: @engcom-Hotel, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Framework Component: Catalog Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: ready for dev Reported on 2.4.5-p1 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it
Projects
Status: Ready for Development
Development

No branches or pull requests

4 participants