Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin not able to create a product without giving name. #35789

Open
5 tasks
engcom-Lima opened this issue Jul 21, 2022 · 16 comments
Open
5 tasks

Admin not able to create a product without giving name. #35789

engcom-Lima opened this issue Jul 21, 2022 · 16 comments
Labels
Area: Product Component: Catalog Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: ready for dev Reported on 2.4.4 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@engcom-Lima
Copy link
Contributor

engcom-Lima commented Jul 21, 2022

Preconditions and environment

  • Install fresh Magento 2.4-develop.

Steps to reproduce

  1. Login as admin.
  2. Go to Store->attributes->product search code "name" and set Values Required to "NO".
  3. Clear cacge
  4. Go to catalog >> products >>Add Product.
  5. Fill all mandatory details. Do not provide name.
  6. Save the product. - Issue. User is not able to save the product without product name
  7. Create the product with Product name and save - Edit product - Remove product name and save - User is able to save the product without name

Expected result

Product should be saved successfully and should be displayed in the product grid.

Actual result

Inconsistent behavior observed when creating the product and editing the product.
Product is not getting created, getting error in frontend. The product that was requested doesn't exist. Verify the product and try again.

Screenshot:
image

Additional information

User is able to save the product without price value (If made not required in attribute configuration) even though it is mandated with * in admin product creation page
image

Release note

No response

Triage and priority

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
@m2-assistant
Copy link

m2-assistant bot commented Jul 21, 2022

Hi @engcom-Lima. Thank you for your report.
To speed up processing of this issue, make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, review the Magento Contributor Assistant documentation.

Add a comment to assign the issue: @magento I am working on this

To learn more about issue processing workflow, refer to the Code Contributions.


⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@m2-assistant
Copy link

m2-assistant bot commented Jul 21, 2022

Hi @engcom-November. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@ajijshekh123
Copy link

@magento give me 2.4-develop instance

@engcom-November
Copy link
Contributor

Hi @engcom-Lima ,
Verified the issue on Magento 2.4-develop branch but however this behavior is due to default Attribute set configuration.
Default attribute set that is used as a template when creating a product includes a set of commonly-used attributes. System attributes are marked with a dot and cannot be removed from the Groups list. They can, however, be dragged to another Group in the attribute set.
Please check the ref guide and provide supporting documents/proofs to consider this as a valid issue.
image
Thank you.

@engcom-November engcom-November added the Issue: needs update Additional information is require, waiting for response label Jul 22, 2022
@engcom-Lima
Copy link
Contributor Author

Hi @engcom-November

I have tested this functionality earlier in 2.4.1 and I was able to create a product without giving name.

The screenshot which you have shared is of product attribute set. Attribute set is the template for product creation. Attribute set is not for making any field mandatory or it will not decide functionality or behaviour.
It is Product attributes, which will decide behaviour of the particular attributes.

For your reference you can see devdocs : product attributes

Here you refer this reply from Magento for a customer query

Thanks

@engcom-November
Copy link
Contributor

@magento give me 2.4-develop instance

@magento-deployment-service
Copy link

Hi @engcom-November. Thank you for your request. I'm working on Magento instance for you.

@magento-deployment-service
Copy link

@engcom-November
Copy link
Contributor

engcom-November commented Jul 25, 2022

Verified the issue again on Magento 2.4-develop branch and the issue is reproducible.
Unable to create Product without Product Name.
image
But if a product is created with name and saved and edited the product without name and saved - User is able to save the product without product name.
Hence confirming this issue for inconsistent behavior and updating description
Similar issue but different error: #35810

@engcom-November engcom-November added Component: Admin Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Area: Product Reported on 2.4.4 Indicates original Magento version for the Issue report. Component: Catalog Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed and removed Component: Admin labels Jul 25, 2022
@m2-community-project m2-community-project bot removed the Issue: needs update Additional information is require, waiting for response label Jul 25, 2022
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.adobe.com/browse/AC-6015 is successfully created for this GitHub issue.

@m2-assistant
Copy link

m2-assistant bot commented Jul 25, 2022

✅ Confirmed by @engcom-November. Thank you for verifying the issue.
Issue Available: @engcom-November, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@github-jira-sync-bot
Copy link

❌ Cannot export the issue. This GitHub issue is already linked to Jira issue(s): https://jira.corp.adobe.com/browse/AC-6015

@engcom-November engcom-November added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Jul 25, 2022
@topanok
Copy link
Contributor

topanok commented Aug 26, 2022

@magento I am working on this

1 similar comment
@topanok
Copy link
Contributor

topanok commented Aug 26, 2022

@magento I am working on this

@topanok topanok mentioned this issue Aug 26, 2022
5 tasks
@engcom-Hotel engcom-Hotel reopened this Oct 14, 2022
@engcom-Bravo engcom-Bravo reopened this Oct 14, 2022
@m2-community-project m2-community-project bot removed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Progress: done labels Oct 14, 2022
@engcom-Hotel engcom-Hotel added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch labels Oct 14, 2022
@github-jira-sync-bot
Copy link

❌ Cannot export the issue. This GitHub issue is already linked to Jira issue(s): https://jira.corp.adobe.com/browse/AC-6015

@topanok
Copy link
Contributor

topanok commented Dec 11, 2022

@engcom-Lima This is not a bug, it cannot generate the url key because it is generated from the product name. Therefore, if you want a product without a name, then enter the key url. I had already created a PR in which I corrected it, but I deleted it, because I think creating a product without a name is stupid)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Product Component: Catalog Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: ready for dev Reported on 2.4.4 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
Status: Ready for Development
Development

Successfully merging a pull request may close this issue.

7 participants