Catalog Pagination not working for custom reindex or bin/magento commands

[andrewdaluz]

Preconditions (*)

1. 2.4.3-p1
2. Running a custom script, reindex or command with bin/magento

Steps to reproduce (*)

1. Create a new Reindex Class or a new Command for bin/magento

2. In that script you run the filtering with searchCriteria with Pagination

3. The pagination or iteration to filter per page goes into an infinite loop because after the last page it's returning the result of the first page.

    $page = 1;
    $searchCriteria = $this->searchCriteriaBuilder
        ->setPageSize(100)
        ->addFilter('make_model', '', 'neq')
        ->addFilter('category_id', [1,2,3], 'in')
        ->create();
   
    for (;;) {
        $searchCriteria->setCurrentPage($page);
        $productList = $this->productRepository->getList($searchCriteria);
        $products = $productList->getItems();
        if ($products) {
            $page++;
        } else {
            break;
        }
    }
   

Expected result (*)

1. With product repository and searchCriteria and Pagination I should be able to get an empty result when the CURRENT PAGE is higher than the last page result.

Actual result (*)

1. The pagination or iteration to filter per page goes into an infinite loop because after the last page it's returning the result of the first page.

---

• Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.

REFERENCE: The issue is caused mainly by this Plugin https://github.com/magento/magento2/blob/2.4-develop/app/code/Magento/Theme/Plugin/Data/Collection.php
I'm wondering if we should use only ElasticSearch collection instead of productRepository filters? The Plugin seems very confusing and it may cause considerable issues I am in doubt why I couldn't find any reported issue since this plugin was introduced on version 2.4.1 as far as I could see on GitHub history.

Commit reference: 663f023

[m2-assistant]

Hi @andrewdaluz. Thank you for your report.
To speed up processing of this issue, make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, review the Magento Contributor Assistant documentation.

Add a comment to assign the issue: @magento I am working on this

To learn more about issue processing workflow, refer to the Code Contributions.

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[m2-assistant]

Hi @engcom-November. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.4-develop branch

  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Add label Issue: Confirmed once verification is complete.

• 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-November]

Hi @andrewdaluz
As per your given steps issue is reproducible as we further investigated this issue is occurring from this plugin \Magento\Theme\Plugin\Data\Collection::afterGetCurPage
Hence confirming the issue.
Thanks.

[github-jira-sync-bot]

✅ Jira issue https://jira.corp.adobe.com/browse/AC-6033 is successfully created for this GitHub issue.

[m2-assistant]

✅ Confirmed by @engcom-November. Thank you for verifying the issue.
Issue Available: @engcom-November, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.