Adding new Vimeo video error

[Michael-073]

I noticed that there are some videos from Vimeo that will return different data. Depending on what data is returned, the script that processes the video can crash.

Preconditions (*)

1. Magento version 2.4.0
2. Patch MDVA-35092 applied

Steps to reproduce (*)

1. Go to Admin -> Catalog ->Products
2. Select a product to edit
3. Go to Images and Videos section. Click Add Video
4. In the Url field, use a video url from Vimeo that is missing required information ( example: https://vimeo.com/313826626 )

Expected result (*)

1. The video information to be filled in and the save button to be enabled.

Actual result (*)

1. No other fields are filled in and the save button remains disabled
2. The following appears in the web browser console

Uncaught TypeError: Cannot read property '0' of null
   at $.<computed].[computed]._formatVimeoDuration (get-video-information.js:592)
   at $.[computed].[computed]._formatVimeoDuration (jquery-ui-1.9.2.js:432)
   at $.[computed].[computed]._onVimeoLoaded (get-video-information.js:502)
   at Object.proxy [as success] (jquery.js:535)
   at fire (jquery.js:3238)
   at Object.fireWith [as resolveWith> (jquery.js:3368)
   at done (jquery.js:9846)
   at HTMLScriptElement.script.onload.script.onreadystatechange (jquery.js:10436)

The _formatVimeoDuration function in the get-video-information.js file has a parameter called seconds. The problem is that seconds is undefined. This is a result of the data returned from Vimeo missing the duration property.

Another error can occur when the description for the video is missing as well

Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

• < ] Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• [ > Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant]

Hi @Michael-073. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[mrtuvn]

Can you reproduce error in latest code base 2.4-develop ? Since i have checked some change in api endpoint vimeo and also some modify in codebase too

[m2-assistant]

Hi @engcom-Oscar. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.4-develop branch

  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Add label Issue: Confirmed once verification is complete.

• 6. Make sure that automatic system confirms that report has been added to the backlog.

[magento-engcom-team]

@engcom-Oscar Thank you for verifying the issue.

Unfortunately, not enough information was provided to acknowledge ticket. Please consider adding the following:

• Add "Reproduced on " label(s) to this ticket based on verification result

Once all required information is added, please add label "Issue: Confirmed" again.
Thanks!