Helper for determining system memory usage on Windows

[witrin]

Hi,

unfortunately the output of tasklist on Windows is language specific. Thus the unit tests always ends with an exception on systems with another language than English (e.g. Speichernutzung in German). Here is the bug. I think possible solutions are:

• Using an index position for the memory column, don't know if this is stable over different versions of Windows,
• detecting the language before and provide for each language the appropriate entry,
• using regular expressions matching for the value,
• or making the column name configurable.

Here is the exception:

Fatal error: Uncaught exception 'InvalidArgumentException' with message 'Number format '' is not recognized.' in [...]\dev\tests\integration\framework\Magento\Test\Helper\Memory.php on line 146

Call Stack:
    0.0003     126624   1. {main}() [...]\phpunit:0
    0.0074     368408   2. PHPUnit_TextUI_Command::main() [...]\phpunit:46
    0.0074     371616   3. PHPUnit_TextUI_Command->run() [...]\PHPUnit\TextUI\Command.php:129

InvalidArgumentException: Number format '' is not recognized. in [...]\dev\tests\integration\framework\Magento\Test\Helper\Memory.php on line 146

Call Stack:
    0.0003     126624   1. {main}() [...]\phpunit:0
    0.0074     368408   2. PHPUnit_TextUI_Command::main() [...]\phpunit:46
    0.0074     371616   3. PHPUnit_TextUI_Command->run() [...]\PHPUnit\TextUI\Command.php:129
   91.1336   22048832   4. Magento_Test_Bootstrap_Memory->displayStats() [...]\dev\tests\integration\framework\Magento\Test\Bootstrap\Memory.php:0
   91.1336   22048952   5. Magento_Test_MemoryLimit->printStats() [...]\dev\tests\integration\framework\Magento\Test\Bootstrap\Memory.php:67
   91.1336   22049080   6. Magento_Test_MemoryLimit->_getUsage() [...]\dev\tests\integration\framework\Magento\Test\MemoryLimit.php:75
   91.1336   22049112   7. Magento_Test_Helper_Memory->getRealMemoryUsage() [...]\dev\tests\integration\framework\Magento\Test\MemoryLimit.php:140
   91.1337   22049200   8. Magento_Test_Helper_Memory->getWinProcessMemoryUsage() [...]\dev\tests\integration\framework\Magento\Test\Helper\Memory.php:66
   92.0006   22051464   9. Magento_Test_Helper_Memory::convertToBytes() [...]\dev\tests\integration\framework\Magento\Test\Helper\Memory.php:119

Best regards,
Artus

[magento-team]

Hello. Would you be able to provide a pull request with a fix (eg making the name configurable)?

[witrin]

Hi,

sure, but I need a name for this configuration entry! I would place it in dev\tests\integration\phpunit.xml.dist as const in the php section. So tell me what name I have to use for this constant and I'll provide a pull request to fix this.

Best regards,
Artus

[magento-team]

Hi. Please use any name you want - and we will rename it if needed during merge. Thanks! We also have similar issue reported internally (#7740) on non-breaking space causing issues (\xA0)

[magento-team]

Closing the issue. The pull request should be used instead.

[serzhik]

Bug still exists on Magento 2.1.2/Windows 10 (default language - Ukrainian or Russian)