Skip to content

Commit fc83279

Browse files
author
Oleksii Korshenko
authored
Merge pull request #27704 from lbajsarowicz/phpunit8/module-Marketplace
#27500 PHPUnit 8 for module Marketplace
2 parents b70ce90 + 1485671 commit fc83279

File tree

5 files changed

+90
-58
lines changed

5 files changed

+90
-58
lines changed

app/code/Magento/Marketplace/Test/Unit/Block/PartnersTest.php

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,23 @@
1-
<?php
1+
<?php declare(strict_types=1);
22
/**
33
* Copyright © Magento, Inc. All rights reserved.
44
* See COPYING.txt for license details.
55
*/
66

77
namespace Magento\Marketplace\Test\Unit\Block;
88

9-
class PartnersTest extends \PHPUnit\Framework\TestCase
9+
use Magento\Marketplace\Block\Partners;
10+
use PHPUnit\Framework\MockObject\MockObject;
11+
use PHPUnit\Framework\TestCase;
12+
13+
class PartnersTest extends TestCase
1014
{
1115
/**
12-
* @var \PHPUnit_Framework_MockObject_MockObject|\Magento\Marketplace\Block\Partners
16+
* @var MockObject|Partners
1317
*/
1418
private $partnersBlockMock;
1519

16-
protected function setUp()
20+
protected function setUp(): void
1721
{
1822
$this->partnersBlockMock = $this->getPartnersBlockMock(
1923
[
@@ -42,17 +46,17 @@ public function testGetPartners()
4246
/**
4347
* Gets partners block mock
4448
*
45-
* @return \PHPUnit_Framework_MockObject_MockObject|\Magento\Marketplace\Block\Partners
49+
* @return MockObject|Partners
4650
*/
4751
public function getPartnersBlockMock($methods = null)
4852
{
49-
return $this->createPartialMock(\Magento\Marketplace\Block\Partners::class, $methods);
53+
return $this->createPartialMock(Partners::class, $methods);
5054
}
5155

5256
/**
5357
* Gets partners model mock
5458
*
55-
* @return \PHPUnit_Framework_MockObject_MockObject|\Magento\Marketplace\Model\Partners
59+
* @return MockObject|\Magento\Marketplace\Model\Partners
5660
*/
5761
public function getPartnersModelMock($methods)
5862
{

app/code/Magento/Marketplace/Test/Unit/Controller/Index/IndexTest.php

Lines changed: 22 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,27 @@
1-
<?php
1+
<?php declare(strict_types=1);
22
/**
33
* Copyright © Magento, Inc. All rights reserved.
44
* See COPYING.txt for license details.
55
*/
66

77
namespace Magento\Marketplace\Test\Unit\Controller\Index;
88

9-
class IndexTest extends \PHPUnit\Framework\TestCase
9+
use Magento\Framework\View\Page\Config;
10+
use Magento\Framework\View\Page\Title;
11+
use Magento\Framework\View\Result\Page;
12+
use Magento\Framework\View\Result\PageFactory;
13+
use Magento\Marketplace\Controller\Adminhtml\Index\Index;
14+
use PHPUnit\Framework\MockObject\MockObject;
15+
use PHPUnit\Framework\TestCase;
16+
17+
class IndexTest extends TestCase
1018
{
1119
/**
12-
* @var \PHPUnit_Framework_MockObject_MockObject| \Magento\Marketplace\Controller\Adminhtml\Index\Index
20+
* @var MockObject|Index
1321
*/
1422
private $indexControllerMock;
1523

16-
protected function setUp()
24+
protected function setUp(): void
1725
{
1826
$this->indexControllerMock = $this->getControllerIndexMock(['getResultPageFactory']);
1927
}
@@ -56,42 +64,42 @@ public function testExecute()
5664
/**
5765
* Gets index controller mock
5866
*
59-
* @return \PHPUnit_Framework_MockObject_MockObject|\Magento\Marketplace\Controller\Adminhtml\Index\Index
67+
* @return MockObject|Index
6068
*/
6169
public function getControllerIndexMock($methods = null)
6270
{
63-
return $this->createPartialMock(\Magento\Marketplace\Controller\Adminhtml\Index\Index::class, $methods);
71+
return $this->createPartialMock(Index::class, $methods);
6472
}
6573

6674
/**
67-
* @return \PHPUnit_Framework_MockObject_MockObject|\Magento\Framework\View\Result\PageFactory
75+
* @return MockObject|PageFactory
6876
*/
6977
public function getResultPageFactoryMock($methods = null)
7078
{
71-
return $this->createPartialMock(\Magento\Framework\View\Result\PageFactory::class, $methods, []);
79+
return $this->createPartialMock(PageFactory::class, $methods, []);
7280
}
7381

7482
/**
75-
* @return \PHPUnit_Framework_MockObject_MockObject|\Magento\Framework\View\Page\Config
83+
* @return MockObject|Config
7684
*/
7785
public function getConfigMock($methods = null)
7886
{
79-
return $this->createPartialMock(\Magento\Framework\View\Page\Config::class, $methods, []);
87+
return $this->createPartialMock(Config::class, $methods, []);
8088
}
8189

8290
/**
83-
* @return \PHPUnit_Framework_MockObject_MockObject|\Magento\Framework\View\Page\Title
91+
* @return MockObject|Title
8492
*/
8593
public function getTitleMock($methods = null)
8694
{
87-
return $this->createPartialMock(\Magento\Framework\View\Page\Title::class, $methods, []);
95+
return $this->createPartialMock(Title::class, $methods, []);
8896
}
8997

9098
/**
91-
* @return \PHPUnit_Framework_MockObject_MockObject|\Magento\Framework\View\Page\Title
99+
* @return MockObject|Title
92100
*/
93101
public function getPageMock($methods = null)
94102
{
95-
return $this->createPartialMock(\Magento\Framework\View\Result\Page::class, $methods, []);
103+
return $this->createPartialMock(Page::class, $methods, []);
96104
}
97105
}

app/code/Magento/Marketplace/Test/Unit/Controller/Partners/IndexTest.php

Lines changed: 25 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,28 @@
1-
<?php
1+
<?php declare(strict_types=1);
22
/**
33
* Copyright © Magento, Inc. All rights reserved.
44
* See COPYING.txt for license details.
55
*/
66

77
namespace Magento\Marketplace\Test\Unit\Controller\Partners;
88

9-
class IndexTest extends \PHPUnit\Framework\TestCase
9+
use Magento\Framework\App\Request\Http;
10+
use Magento\Framework\HTTP\PhpEnvironment\Response;
11+
use Magento\Framework\View\Element\BlockInterface;
12+
use Magento\Framework\View\LayoutFactory;
13+
use Magento\Framework\View\LayoutInterface;
14+
use Magento\Marketplace\Controller\Adminhtml\Partners\Index;
15+
use PHPUnit\Framework\MockObject\MockObject;
16+
use PHPUnit\Framework\TestCase;
17+
18+
class IndexTest extends TestCase
1019
{
1120
/**
12-
* @var \PHPUnit_Framework_MockObject_MockObject|\Magento\Marketplace\Controller\Adminhtml\Partners\Index
21+
* @var MockObject|Index
1322
*/
1423
private $partnersControllerMock;
1524

16-
protected function setUp()
25+
protected function setUp(): void
1726
{
1827
$this->partnersControllerMock = $this->getControllerIndexMock(
1928
[
@@ -71,50 +80,50 @@ public function testExecute()
7180
/**
7281
* Gets partners controller mock
7382
*
74-
* @return \PHPUnit_Framework_MockObject_MockObject|\Magento\Marketplace\Controller\Adminhtml\Partners\Index
83+
* @return MockObject|Index
7584
*/
7685
public function getControllerIndexMock($methods = null)
7786
{
78-
return $this->createPartialMock(\Magento\Marketplace\Controller\Adminhtml\Partners\Index::class, $methods);
87+
return $this->createPartialMock(Index::class, $methods);
7988
}
8089

8190
/**
82-
* @return \PHPUnit_Framework_MockObject_MockObject|\Magento\Framework\View\LayoutFactory
91+
* @return MockObject|LayoutFactory
8392
*/
8493
public function getLayoutFactoryMock($methods = null)
8594
{
86-
return $this->createPartialMock(\Magento\Framework\View\LayoutFactory::class, $methods, []);
95+
return $this->createPartialMock(LayoutFactory::class, $methods, []);
8796
}
8897

8998
/**
90-
* @return \PHPUnit_Framework_MockObject_MockObject|\Magento\Framework\View\LayoutInterface
99+
* @return MockObject|LayoutInterface
91100
*/
92101
public function getLayoutMock()
93102
{
94-
return $this->getMockForAbstractClass(\Magento\Framework\View\LayoutInterface::class);
103+
return $this->getMockForAbstractClass(LayoutInterface::class);
95104
}
96105

97106
/**
98-
* @return \PHPUnit_Framework_MockObject_MockObject|\Magento\Framework\HTTP\PhpEnvironment\Response
107+
* @return MockObject|Response
99108
*/
100109
public function getResponseMock($methods = null)
101110
{
102-
return $this->createPartialMock(\Magento\Framework\HTTP\PhpEnvironment\Response::class, $methods, []);
111+
return $this->createPartialMock(Response::class, $methods, []);
103112
}
104113

105114
/**
106-
* @return \PHPUnit_Framework_MockObject_MockObject|\Magento\Framework\App\Request\Http
115+
* @return MockObject|Http
107116
*/
108117
public function getRequestMock($methods = null)
109118
{
110-
return $this->createPartialMock(\Magento\Framework\App\Request\Http::class, $methods, []);
119+
return $this->createPartialMock(Http::class, $methods, []);
111120
}
112121

113122
/**
114-
* @return \PHPUnit_Framework_MockObject_MockObject|\Magento\Framework\View\Element\BlockInterface
123+
* @return MockObject|BlockInterface
115124
*/
116125
public function getBlockInterfaceMock()
117126
{
118-
return $this->getMockForAbstractClass(\Magento\Framework\View\Element\BlockInterface::class);
127+
return $this->getMockForAbstractClass(BlockInterface::class);
119128
}
120129
}

app/code/Magento/Marketplace/Test/Unit/Helper/CacheTest.php

Lines changed: 14 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,37 +1,42 @@
1-
<?php
1+
<?php declare(strict_types=1);
22
/**
33
* Copyright © Magento, Inc. All rights reserved.
44
* See COPYING.txt for license details.
55
*/
66

77
namespace Magento\Marketplace\Test\Unit\Helper;
88

9+
use Magento\Framework\Config\CacheInterface;
910
use Magento\Framework\Serialize\SerializerInterface;
11+
use Magento\Framework\TestFramework\Unit\Helper\ObjectManager;
12+
use Magento\Marketplace\Helper\Cache;
13+
use PHPUnit\Framework\MockObject\MockObject;
14+
use PHPUnit\Framework\TestCase;
1015

11-
class CacheTest extends \PHPUnit\Framework\TestCase
16+
class CacheTest extends TestCase
1217
{
1318
/**
14-
* @var \Magento\Framework\Config\CacheInterface|\PHPUnit_Framework_MockObject_MockObject
19+
* @var CacheInterface|MockObject
1520
*/
1621
private $cache;
1722

1823
/**
19-
* @var SerializerInterface|\PHPUnit_Framework_MockObject_MockObject
24+
* @var SerializerInterface|MockObject
2025
*/
2126
private $serializer;
2227

2328
/**
24-
* @var \Magento\Marketplace\Helper\Cache
29+
* @var Cache
2530
*/
2631
private $cacheHelper;
2732

28-
protected function setUp()
33+
protected function setUp(): void
2934
{
30-
$this->cache = $this->getMockForAbstractClass(\Magento\Framework\Config\CacheInterface::class);
35+
$this->cache = $this->getMockForAbstractClass(CacheInterface::class);
3136
$this->serializer = $this->getMockForAbstractClass(SerializerInterface::class);
32-
$objectManagerHelper = new \Magento\Framework\TestFramework\Unit\Helper\ObjectManager($this);
37+
$objectManagerHelper = new ObjectManager($this);
3338
$this->cacheHelper = $objectManagerHelper->getObject(
34-
\Magento\Marketplace\Helper\Cache::class,
39+
Cache::class,
3540
[
3641
'cache' => $this->cache,
3742
'serializer' => $this->serializer,

app/code/Magento/Marketplace/Test/Unit/Model/PartnersTest.php

Lines changed: 18 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,21 @@
1-
<?php
1+
<?php declare(strict_types=1);
22
/**
33
* Copyright © Magento, Inc. All rights reserved.
44
* See COPYING.txt for license details.
55
*/
66

77
namespace Magento\Marketplace\Test\Unit\Model;
88

9-
class PartnersTest extends \PHPUnit\Framework\TestCase
9+
use Magento\Framework\HTTP\Client\Curl;
10+
use Magento\Marketplace\Helper\Cache;
11+
use Magento\Marketplace\Model\Partners;
12+
use PHPUnit\Framework\MockObject\MockObject;
13+
use PHPUnit\Framework\TestCase;
14+
15+
class PartnersTest extends TestCase
1016
{
1117
/**
12-
* @var \PHPUnit_Framework_MockObject_MockObject|\Magento\Marketplace\Model\Partners
18+
* @var MockObject|Partners
1319
*/
1420
private $partnersModelMock;
1521

@@ -33,7 +39,7 @@ class PartnersTest extends \PHPUnit\Framework\TestCase
3339
}
3440
}';
3541

36-
protected function setUp()
42+
protected function setUp(): void
3743
{
3844
$this->partnersModelMock = $this->getPartnersModelMock(
3945
[
@@ -97,7 +103,7 @@ public function testGetPartnersException()
97103
->method('post');
98104
$curlMock->expects($this->once())
99105
->method('getBody')
100-
->will($this->throwException(new \Exception));
106+
->will($this->throwException(new \Exception()));
101107
$this->partnersModelMock->expects($this->exactly(3))
102108
->method('getCurlClient')
103109
->will($this->returnValue($curlMock));
@@ -119,7 +125,7 @@ public function testGetPartnersException()
119125
/**
120126
* Gets partners block mock
121127
*
122-
* @return \PHPUnit_Framework_MockObject_MockObject|\Magento\Marketplace\Block\Partners
128+
* @return MockObject|\Magento\Marketplace\Block\Partners
123129
*/
124130
public function getPartnersBlockMock($methods = null)
125131
{
@@ -129,30 +135,30 @@ public function getPartnersBlockMock($methods = null)
129135
/**
130136
* Gets partners model mock
131137
*
132-
* @return \PHPUnit_Framework_MockObject_MockObject|\Magento\Marketplace\Model\Partners
138+
* @return MockObject|Partners
133139
*/
134140
public function getPartnersModelMock($methods)
135141
{
136-
return $this->createPartialMock(\Magento\Marketplace\Model\Partners::class, $methods, []);
142+
return $this->createPartialMock(Partners::class, $methods, []);
137143
}
138144

139145
/**
140146
* Gets partners model mock
141147
*
142-
* @return \PHPUnit_Framework_MockObject_MockObject|\Magento\Framework\HTTP\Client\Curl
148+
* @return MockObject|Curl
143149
*/
144150
public function getCurlMock($methods)
145151
{
146-
return $this->createPartialMock(\Magento\Framework\HTTP\Client\Curl::class, $methods, []);
152+
return $this->createPartialMock(Curl::class, $methods, []);
147153
}
148154

149155
/**
150156
* Gets cache mock
151157
*
152-
* @return \PHPUnit_Framework_MockObject_MockObject|\Magento\Framework\HTTP\Client\Curl
158+
* @return MockObject|Curl
153159
*/
154160
public function getCacheMock($methods)
155161
{
156-
return $this->createPartialMock(\Magento\Marketplace\Helper\Cache::class, $methods, []);
162+
return $this->createPartialMock(Cache::class, $methods, []);
157163
}
158164
}

0 commit comments

Comments
 (0)