MC-22213: Implementation - Merge cart

- review fixes

Author: Prabhu Ram

app/code/Magento/QuoteGraphQl/Model/Resolver/MergeCarts.php

@@ -12,6 +12,7 @@
 use Magento\Framework\GraphQl\Query\ResolverInterface;
 use Magento\Framework\GraphQl\Schema\Type\ResolveInfo;
 use Magento\QuoteGraphQl\Model\Cart\GetCartForUser;
+use Magento\Quote\Api\CartRepositoryInterface;
 
 /**
  * Merge Carts Resolver
@@ -23,13 +24,21 @@ class MergeCarts implements ResolverInterface
      */
     private $getCartForUser;
 
+    /**
+     * @var CartRepositoryInterface
+     */
+    private $cartRepository;
+
     /**
      * @param GetCartForUser $getCartForUser
+     * @param CartRepositoryInterface $cartRepository
      */
     public function __construct(
-        GetCartForUser $getCartForUser
+        GetCartForUser $getCartForUser,
+        CartRepositoryInterface $cartRepository
     ) {
         $this->getCartForUser = $getCartForUser;
+        $this->cartRepository = $cartRepository;
     }
 
     /**
@@ -38,7 +47,7 @@ public function __construct(
     public function resolve(Field $field, $context, ResolveInfo $info, array $value = null, array $args = null)
     {
         if (empty($args['source_cart_id'])) {
-            throw new GraphQlInputException(__('Required parameter "cart_id" is missing'));
+            throw new GraphQlInputException(__('Required parameter "source_cart_id" is missing'));
         }
 
         if (empty($args['destination_cart_id'])) {
@@ -49,12 +58,14 @@ public function resolve(Field $field, $context, ResolveInfo $info, array $value
         $customerMaskedCartId = $args['destination_cart_id'];
 
         $currentUserId = $context->getUserId();
-        $storeId = $storeId = (int)$context->getExtensionAttributes()->getStore()->getId();
+        $storeId = (int)$context->getExtensionAttributes()->getStore()->getId();
         // passing customerId as null enforces source cart should always be a guestcart
         $guestCart = $this->getCartForUser->execute($guestMaskedCartId, null, $storeId);
         $customerCart = $this->getCartForUser->execute($customerMaskedCartId, $currentUserId, $storeId);
         $customerCart->merge($guestCart);
-
+        $guestCart->setIsActive(false);
+        $this->cartRepository->save($customerCart);
+        $this->cartRepository->save($guestCart);
         return [
             'model' => $customerCart,
         ];

app/code/Magento/QuoteGraphQl/etc/schema.graphqls

@@ -19,7 +19,7 @@ type Mutation {
     setPaymentMethodOnCart(input: SetPaymentMethodOnCartInput): SetPaymentMethodOnCartOutput @resolver(class: "Magento\\QuoteGraphQl\\Model\\Resolver\\SetPaymentMethodOnCart")
     setGuestEmailOnCart(input: SetGuestEmailOnCartInput): SetGuestEmailOnCartOutput @resolver(class: "Magento\\QuoteGraphQl\\Model\\Resolver\\SetGuestEmailOnCart")
     setPaymentMethodAndPlaceOrder(input: SetPaymentMethodAndPlaceOrderInput): PlaceOrderOutput @deprecated(reason: "Should use setPaymentMethodOnCart and placeOrder mutations in single request.") @resolver(class: "\\Magento\\QuoteGraphQl\\Model\\Resolver\\SetPaymentAndPlaceOrder")
-    mergeCarts(source_cart_id: String, destination_cart_id: String): Cart! @doc(description:"Merges source cart into the destination cart") @resolver(class: "Magento\\QuoteGraphQl\\Model\\Resolver\\MergeCarts")
+    mergeCarts(source_cart_id: String!, destination_cart_id: String!): Cart! @doc(description:"Merges the source cart into the destination cart") @resolver(class: "Magento\\QuoteGraphQl\\Model\\Resolver\\MergeCarts")
     placeOrder(input: PlaceOrderInput): PlaceOrderOutput @resolver(class: "\\Magento\\QuoteGraphQl\\Model\\Resolver\\PlaceOrder")
 }