CABPI-227: setup new plugins

 - add two new plugins for removing fields and fieldsets,
 - update readme with tasks

Author: dmanners

app/code/Magento/AdminAdobeIms/Plugin/RemoveCurrentUserVerificationFieldPlugin.php

@@ -0,0 +1,52 @@
+<?php
+
+namespace Magento\AdminAdobeIms\Plugin;
+
+use Magento\AdminAdobeIms\Service\ImsConfig;
+use Magento\Framework\Data\Form\Element\AbstractElement;
+use Magento\Framework\Data\Form\Element\Fieldset;
+
+class RemoveCurrentUserVerificationFieldPlugin
+{
+    /** @var ImsConfig */
+    private ImsConfig $imsConfig;
+
+    /**
+     * @param ImsConfig $imsConfig
+     */
+    public function __construct(
+        ImsConfig $imsConfig
+    ) {
+        $this->imsConfig = $imsConfig;
+    }
+
+    /**
+     * @param Fieldset $subject
+     * @param AbstractElement $result
+     * @param string $elementId
+     * @param string $type
+     * @param array $config
+     * @param bool $after
+     * @param bool $isAdvanced
+     * @return AbstractElement
+     */
+    public function afterAddField(
+        Fieldset $subject,
+        AbstractElement $result,
+        $elementId,
+        $type,
+        $config,
+        $after = false,
+        $isAdvanced = false
+    ): AbstractElement {
+        if ($elementId !== \Magento\Backend\Block\System\Account\Edit\Form::IDENTITY_VERIFICATION_PASSWORD_FIELD) {
+            return $result;
+        }
+        if ($this->imsConfig->enabled() !== true) {
+            return $result;
+        }
+
+        $subject->removeField($elementId);
+        return $result;
+    }
+}

app/code/Magento/AdminAdobeIms/Plugin/RemoveCurrentUserVerificationFieldsetPlugin.php

@@ -0,0 +1,50 @@
+<?php
+
+namespace Magento\AdminAdobeIms\Plugin;
+
+use Magento\AdminAdobeIms\Service\ImsConfig;
+use Magento\Framework\Data\Form\AbstractForm;
+use Magento\Framework\Data\Form\Element\Fieldset;
+
+class RemoveCurrentUserVerificationFieldsetPlugin
+{
+    /** @var ImsConfig */
+    private ImsConfig $imsConfig;
+
+    /**
+     * @param ImsConfig $imsConfig
+     */
+    public function __construct(
+        ImsConfig $imsConfig
+    ) {
+        $this->imsConfig = $imsConfig;
+    }
+
+    /**
+     * @param AbstractForm $subject
+     * @param Fieldset $result
+     * @param string $elementId
+     * @param array $config
+     * @param bool|string|null $after
+     * @param bool $isAdvanced
+     * @return Fieldset
+     */
+    public function afterAddFieldset(
+        AbstractForm $subject,
+        Fieldset $result,
+        $elementId,
+        $config,
+        $after = false,
+        $isAdvanced = false)
+    : Fieldset {
+        if ($elementId !== 'current_user_verification_fieldset') {
+            return $result;
+        }
+        if ($this->imsConfig->enabled() !== true) {
+            return $result;
+        }
+
+        $subject->removeField($elementId);
+        return $result;
+    }
+}

app/code/Magento/AdminAdobeIms/README.md

@@ -120,3 +120,12 @@ Errors are logged into the `/var/log/admin_adobe_ims.log` file.
 
 Logging can be enabled or disabled in the config on changing the value for `adobe_ims\integration\logging_enabled` or in the Magento Admin Configuration under `Advanced > Developer > Debug`. \
 There you can switch the toggle for `Enable Logging for Admin Adobe IMS Module`
+
+# Password usage in Admin UI
+1. Remove current user password verification from form,
+2. Remove admin user set of passwords,
+3. Check that it is still updating the admin user information,
+4. Remove password refresh options from config,
+5. Validate that crons etc dont happen,
+6. Validate that when disabled the fields work again,
+7. Update Wiki

app/code/Magento/AdminAdobeIms/etc/adminhtml/di.xml

@@ -29,4 +29,13 @@
             </argument>
         </arguments>
     </type>
+
+    <type name="Magento\Framework\Data\Form\AbstractForm">
+        <plugin name="afterAddFieldset"
+                type="Magento\AdminAdobeIms\Plugin\RemoveCurrentUserVerificationFieldsetPlugin"/>
+    </type>
+    <type name="Magento\Framework\Data\Form\Element\Fieldset">
+        <plugin name="afterAddField"
+                type="Magento\AdminAdobeIms\Plugin\RemoveCurrentUserVerificationFieldPlugin"/>
+    </type>
 </config>