MC-32402: [Magento Cloud] - tax calculation with b2b extension

Author: nikita-shcherbatykh

app/code/Magento/Catalog/Model/Indexer/Product/Price/Plugin/CustomerGroup.php

@@ -15,6 +15,9 @@
 use Magento\Customer\Model\Indexer\CustomerGroupDimensionProvider;
 use Magento\Store\Model\Indexer\WebsiteDimensionProvider;
 
+/**
+ * Update catalog_product_index_price table after delete or save customer group
+ */
 class CustomerGroup
 {
     /**
@@ -80,7 +83,7 @@ public function aroundSave(
         \Closure $proceed,
         GroupInterface $group
     ) {
-        $isGroupNew = !$group->getId();
+        $isGroupNew = $group->getId() === null;
         $group = $proceed($group);
         if ($isGroupNew) {
             foreach ($this->getAffectedDimensions((string)$group->getId()) as $dimensions) {

app/code/Magento/Catalog/Test/Unit/Model/Indexer/Product/Price/Plugin/CustomerGroupTest.php

@@ -0,0 +1,132 @@
+<?php
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+namespace Magento\Catalog\Test\Unit\Model\Indexer\Product\Price\Plugin;
+
+use Magento\Catalog\Model\Indexer\Product\Price\DimensionModeConfiguration;
+use Magento\Catalog\Model\Indexer\Product\Price\Plugin\CustomerGroup;
+use Magento\Catalog\Model\Indexer\Product\Price\TableMaintainer;
+use Magento\Customer\Api\GroupRepositoryInterface;
+use Magento\Customer\Model\Data\Group;
+use Magento\Customer\Model\Indexer\CustomerGroupDimensionProvider;
+use Magento\Framework\Indexer\DimensionFactory;
+use Magento\Framework\TestFramework\Unit\Helper\ObjectManager;
+use PHPUnit\Framework\MockObject\MockObject;
+
+/**
+ * Test for CustomerGroup plugin
+ */
+class CustomerGroupTest extends \PHPUnit\Framework\TestCase
+{
+    /**
+     * @var ObjectManager
+     */
+    private $objectManager;
+
+    /**
+     * @var CustomerGroup
+     */
+    private $model;
+
+    /**
+     * @var DimensionFactory|MockObject
+     */
+    private $dimensionFactory;
+
+    /**
+     * @var TableMaintainer|MockObject
+     */
+    private $tableMaintainerMock;
+
+    /**
+     * @var DimensionModeConfiguration|MockObject
+     */
+    private $dimensionModeConfiguration;
+
+    /**
+     * @var \Callable
+     */
+    private $proceedMock;
+
+    protected function setUp()
+    {
+        $this->objectManager = new ObjectManager($this);
+
+        $this->dimensionFactory = $this->createPartialMock(
+            DimensionFactory::class,
+            ['create']
+        );
+
+        $this->dimensionModeConfiguration = $this->createPartialMock(
+            DimensionModeConfiguration::class,
+            ['getDimensionConfiguration']
+        );
+
+        $this->tableMaintainerMock = $this->createPartialMock(
+            TableMaintainer::class,
+            ['createTablesForDimensions']
+        );
+
+        $this->model = $this->objectManager->getObject(
+            CustomerGroup::class,
+            [
+                'dimensionFactory' => $this->dimensionFactory,
+                'dimensionModeConfiguration' => $this->dimensionModeConfiguration,
+                'tableMaintainer' => $this->tableMaintainerMock,
+            ]
+        );
+    }
+
+    /**
+     * Check of call count createTablesForDimensions() method
+     *
+     * @param $customerGroupId
+     * @param $callTimes
+     *
+     * @dataProvider aroundSaveDataProvider
+     */
+    public function testAroundSave($customerGroupId, $callTimes)
+    {
+        $subjectMock = $this->createMock(GroupRepositoryInterface::class);
+        $customerGroupMock = $this->createPartialMock(
+            Group::class,
+            ['getId']
+        );
+        $customerGroupMock->method('getId')->willReturn($customerGroupId);
+        $this->tableMaintainerMock->expects(
+            $this->exactly($callTimes)
+        )->method('createTablesForDimensions');
+        $this->proceedMock = function ($customerGroupMock) {
+            return $customerGroupMock;
+        };
+        $this->dimensionModeConfiguration->method('getDimensionConfiguration')->willReturn(
+            [CustomerGroupDimensionProvider::DIMENSION_NAME]
+        );
+        $this->model->aroundSave($subjectMock, $this->proceedMock, $customerGroupMock);
+    }
+
+    /**
+     * Data provider for testAroundSave
+     *
+     * @return array
+     */
+    public function aroundSaveDataProvider()
+    {
+        return [
+            'customer_group_id = 0' => [
+                'customer_group_id' => '0',
+                'create_tables_call_times' => 0
+            ],
+            'customer_group_id = 1' => [
+                'customer_group_id' => '1',
+                'create_tables_call_times' => 0
+            ],
+            'customer_group_id = null' => [
+                'customer_group_id' => null,
+                'create_tables_call_times' => 1
+            ],
+        ];
+    }
+}