Skip to content

Commit 7402c67

Browse files
committed
Fixed coding standard violations in the Framework\Locale namespace, so that it will be checked bij PHP CS and no longer be ignored while doing CI checks. Made the following changes:
- Removed @codingStandardsIgnoreFile from the head of the file - Fixed indentation - Fixed missing parameter in docblock comment
1 parent c3040d3 commit 7402c67

File tree

3 files changed

+4
-9
lines changed

3 files changed

+4
-9
lines changed

lib/internal/Magento/Framework/Locale/Test/Unit/ConfigTest.php

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,6 @@
44
* See COPYING.txt for license details.
55
*/
66

7-
// @codingStandardsIgnoreFile
8-
97
namespace Magento\Framework\Locale\Test\Unit;
108

119
class ConfigTest extends \PHPUnit_Framework_TestCase
@@ -43,9 +41,9 @@ class ConfigTest extends \PHPUnit_Framework_TestCase
4341
];
4442

4543
private static $samplePresentLocales = [
46-
'en_US', 'lv_LV', 'pt_BR', 'it_IT', 'ar_EG', 'bg_BG', 'en_IE', 'es_ES',
47-
'en_AU', 'pt_PT', 'ru_RU', 'en_CA', 'vi_VN', 'ja_JP', 'en_GB', 'zh_CN',
48-
'zh_TW', 'fr_FR', 'ar_KW', 'pl_PL', 'ko_KR', 'sk_SK', 'el_GR', 'hi_IN',
44+
'en_US', 'lv_LV', 'pt_BR', 'it_IT', 'ar_EG', 'bg_BG', 'en_IE', 'es_ES',
45+
'en_AU', 'pt_PT', 'ru_RU', 'en_CA', 'vi_VN', 'ja_JP', 'en_GB', 'zh_CN',
46+
'zh_TW', 'fr_FR', 'ar_KW', 'pl_PL', 'ko_KR', 'sk_SK', 'el_GR', 'hi_IN',
4947
];
5048

5149
private static $sampleAbsentLocales = [

lib/internal/Magento/Framework/Locale/Test/Unit/CurrencyTest.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,6 @@
44
* See COPYING.txt for license details.
55
*/
66

7-
// @codingStandardsIgnoreFile
8-
97
namespace Magento\Framework\Locale\Test\Unit;
108

119
use Magento\Framework\Locale\Currency;

lib/internal/Magento/Framework/Locale/TranslatedLists.php

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,6 @@
44
* See COPYING.txt for license details.
55
*/
66

7-
// @codingStandardsIgnoreFile
8-
97
namespace Magento\Framework\Locale;
108

119
use Magento\Framework\Locale\Bundle\CurrencyBundle;
@@ -26,6 +24,7 @@ class TranslatedLists implements ListsInterface
2624
protected $localeResolver;
2725

2826
/**
27+
* @param \Magento\Framework\Locale\ConfigInterface $config
2928
* @param \Magento\Framework\Locale\ResolverInterface $localeResolver
3029
* @param string $locale
3130
*/

0 commit comments

Comments
 (0)