Skip to content

Commit 484b79a

Browse files
committed
Fix static tests.
1 parent 1f5ec6f commit 484b79a

File tree

1 file changed

+31
-16
lines changed

1 file changed

+31
-16
lines changed

app/code/Magento/Deploy/Collector/Collector.php

Lines changed: 31 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,10 @@
55
*/
66
namespace Magento\Deploy\Collector;
77

8-
use Magento\Deploy\Source\SourcePool;
98
use Magento\Deploy\Package\Package;
109
use Magento\Deploy\Package\PackageFactory;
10+
use Magento\Deploy\Source\SourcePool;
11+
use Magento\Deploy\Package\PackageFile;
1112
use Magento\Framework\Module\Manager;
1213
use Magento\Framework\View\Asset\PreProcessor\FileNameResolver;
1314

@@ -44,7 +45,7 @@ class Collector implements CollectorInterface
4445
* @var PackageFactory
4546
*/
4647
private $packageFactory;
47-
48+
4849
/** @var \Magento\Framework\Module\Manager */
4950
private $moduleManager;
5051

@@ -65,18 +66,19 @@ class Collector implements CollectorInterface
6566
* @param SourcePool $sourcePool
6667
* @param FileNameResolver $fileNameResolver
6768
* @param PackageFactory $packageFactory
69+
* @param Manager $moduleManager
6870
*/
6971
public function __construct(
7072
SourcePool $sourcePool,
7173
FileNameResolver $fileNameResolver,
7274
PackageFactory $packageFactory,
73-
Manager $moduleManager = null
75+
Manager $moduleManager = null
7476
) {
7577
$this->sourcePool = $sourcePool;
7678
$this->fileNameResolver = $fileNameResolver;
7779
$this->packageFactory = $packageFactory;
7880
$this->moduleManager = $moduleManager ?: \Magento\Framework\App\ObjectManager::getInstance()
79-
->get(\Magento\Framework\Module\Manager::class);
81+
->get(Manager::class);
8082
}
8183

8284
/**
@@ -92,18 +94,7 @@ public function collect()
9294
continue;
9395
}
9496
$file->setDeployedFileName($this->fileNameResolver->resolve($file->getFileName()));
95-
$params = [
96-
'area' => $file->getArea(),
97-
'theme' => $file->getTheme(),
98-
'locale' => $file->getLocale(),
99-
'module' => $file->getModule(),
100-
'isVirtual' => (!$file->getLocale() || !$file->getTheme() || !$file->getArea())
101-
];
102-
foreach ($this->packageDefaultValues as $name => $value) {
103-
if (!isset($params[$name])) {
104-
$params[$name] = $value;
105-
}
106-
}
97+
$params = $this->getParams($file);
10798
$packagePath = "{$params['area']}/{$params['theme']}/{$params['locale']}";
10899
if (!isset($packages[$packagePath])) {
109100
$packages[$packagePath] = $this->packageFactory->create($params);
@@ -115,4 +106,28 @@ public function collect()
115106
}
116107
return $packages;
117108
}
109+
110+
/**
111+
* Retrieve package params.
112+
*
113+
* @param PackageFile $file
114+
* @return array
115+
*/
116+
private function getParams(PackageFile $file)
117+
{
118+
$params = [
119+
'area' => $file->getArea(),
120+
'theme' => $file->getTheme(),
121+
'locale' => $file->getLocale(),
122+
'module' => $file->getModule(),
123+
'isVirtual' => (!$file->getLocale() || !$file->getTheme() || !$file->getArea())
124+
];
125+
foreach ($this->packageDefaultValues as $name => $value) {
126+
if (!isset($params[$name])) {
127+
$params[$name] = $value;
128+
}
129+
}
130+
131+
return $params;
132+
}
118133
}

0 commit comments

Comments
 (0)