ENGCOM-2113: [Backport] array_push(...) calls behaving as '$array[] = ...', $array[] = works faster than invoking functions in PHP #16359

Author: Stanislav Idolov

app/code/Magento/Checkout/Block/Checkout/AttributeMerger.php

@@ -377,9 +377,9 @@ protected function orderCountryOptions(array $countryOptions)
         ]];
         foreach ($countryOptions as $countryOption) {
             if (empty($countryOption['value']) || in_array($countryOption['value'], $this->topCountryCodes)) {
-                array_push($headOptions, $countryOption);
+                $headOptions[] = $countryOption;
             } else {
-                array_push($tailOptions, $countryOption);
+                $tailOptions[] = $countryOption;
             }
 
         }

app/code/Magento/Checkout/Block/Checkout/DirectoryDataProcessor.php

@@ -136,9 +136,9 @@ private function orderCountryOptions(array $countryOptions)
         ]];
         foreach ($countryOptions as $countryOption) {
             if (empty($countryOption['value']) || in_array($countryOption['value'], $topCountryCodes)) {
-                array_push($headOptions, $countryOption);
+                $headOptions[] = $countryOption;
             } else {
-                array_push($tailOptions, $countryOption);
+                $tailOptions[] = $countryOption;
             }
         }
         return array_merge($headOptions, $tailOptions);

app/code/Magento/ImportExport/Model/Report/Csv.php

@@ -77,7 +77,7 @@ public function createReport(
         $outputCsv = $this->createOutputCsvModel($outputFileName);
 
         $columnsName = $sourceCsv->getColNames();
-        array_push($columnsName, self::REPORT_ERROR_COLUMN_NAME);
+        $columnsName[] = self::REPORT_ERROR_COLUMN_NAME;
         $outputCsv->setHeaderCols($columnsName);
 
         foreach ($sourceCsv as $rowNum => $rowData) {

app/code/Magento/Quote/Model/Quote.php

@@ -2001,7 +2001,7 @@ public function getErrors()
         foreach ($this->getMessages() as $message) {
             /* @var $error \Magento\Framework\Message\AbstractMessage */
             if ($message->getType() == \Magento\Framework\Message\MessageInterface::TYPE_ERROR) {
-                array_push($errors, $message);
+                $errors[] = $message;
             }
         }
         return $errors;

app/code/Magento/SalesRule/Model/Validator.php

@@ -508,7 +508,7 @@ public function sortItemsByPriority($items, Address $address = null)
             foreach ($items as $itemKey => $itemValue) {
                 if ($rule->getActions()->validate($itemValue)) {
                     unset($items[$itemKey]);
-                    array_push($itemsSorted, $itemValue);
+                    $itemsSorted[] = $itemValue;
                 }
             }
         }

lib/internal/Magento/Framework/Webapi/Rest/Response/FieldsFilter.php

@@ -104,9 +104,9 @@ protected function parse($filterString)
             }
             switch ($filterString[$position]) {
                 case '[':
-                    array_push($parent, $currentElement);
+                    $parent[] = $currentElement;
                     // push current field in stack and initialize current
-                    array_push($stack, $current);
+                    $stack[] = $current;
                     $current = [];
                     break;
 

setup/src/Magento/Setup/Module/Dependency/Circular.php

@@ -118,7 +118,7 @@ protected function buildCircular($modules)
             return;
         }
         $this->circularDependencies[$path] = $modules;
-        array_push($modules, array_shift($modules));
+        $modules[] = array_shift($modules);
         $this->buildCircular($modules);
     }
 
@@ -133,7 +133,7 @@ protected function divideByModules($circularDependencies)
         $dependenciesByModule = [];
         foreach ($circularDependencies as $circularDependency) {
             $module = $circularDependency[0];
-            array_push($circularDependency, $module);
+            $circularDependency[] = $module;
             $dependenciesByModule[$module][] = $circularDependency;
         }
 

setup/src/Magento/Setup/Module/Di/Code/Scanner/XmlInterceptorScanner.php

@@ -42,9 +42,9 @@ protected function _collectEntitiesFromString($content)
             $attributes = $entityNode->attributes;
             $type = $attributes->getNamedItem('type');
             if ($type !== null) {
-                array_push($output, $type->nodeValue);
+                $output[] = $type->nodeValue;
             } else {
-                array_push($output, $attributes->getNamedItem('name')->nodeValue);
+                $output[] = $attributes->getNamedItem('name')->nodeValue;
             }
         }
         return $output;
@@ -80,7 +80,7 @@ protected function _filterEntities(array $output)
                 $this->_handleControllerClassName($entityName);
             }
             if (class_exists($entityName) || interface_exists($entityName)) {
-                array_push($filteredEntities, $entityName . '\\Interceptor');
+                $filteredEntities[] = $entityName . '\\Interceptor';
             }
         }
         return $filteredEntities;

setup/src/Magento/Setup/Module/Di/Code/Scanner/XmlScanner.php

@@ -72,7 +72,7 @@ protected function _filterEntities(array $output)
             }
             if (false === $isClassExists) {
                 if (class_exists($entityName) || interface_exists($entityName)) {
-                    array_push($filteredEntities, $className);
+                    $filteredEntities[] = $className;
                 } else {
                     $this->_log->add(
                         \Magento\Setup\Module\Di\Compiler\Log\Log::CONFIGURATION_ERROR,