Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link Review Sample Data to existing Customers #136

Open
wants to merge 4 commits into
base: 2.3-develop
Choose a base branch
from

Conversation

sertlab
Copy link

@sertlab sertlab commented Dec 9, 2019

At the moment although there are some reviews in ReviewSampleData that belongs to an existing customer "roni_cost@example.com", after Sample Data Installation those reviews are still belongs to a guest. This PR solves that.

What Changed

  • In module ReviewSampleData added a dependency Magento_CustomerSampleData to make sure that customer exists before install ReviewSampleData
  • I removed some doublicate reviews.

How to review/test

  • Before checkout to the branch install Sample Data go to Marketing > All Reviews and search for "customer" reviews. No one exists

  • After Checkout to this branch repeat the same. Now you will find reviews that belongs to a customer

@ghost ghost added 2.3-develop: 3️⃣ 2.3-develop: :three: 2.3-develop: 2️⃣ 2.3-develop: :two: 2.3-develop: 1️⃣ 2.3-develop: :one: and removed 2.3-develop: 3️⃣ 2.3-develop: :three: 2.3-develop: 2️⃣ 2.3-develop: :two: 2.3-develop: 1️⃣ 2.3-develop: :one: labels Dec 9, 2019
@ghost ghost added 2.3-develop: 1️⃣ 2.3-develop: :one: and removed 2.3-develop: 1️⃣ 2.3-develop: :one: labels Dec 10, 2019
@lenaorobei lenaorobei added 2.3-develop: exclude 2.3-develop: exclude and removed 2.3-develop: 1️⃣ 2.3-develop: :one: labels Dec 11, 2019
@ghost ghost added 2.3-develop: 1️⃣ 2.3-develop: :one: and removed 2.3-develop: 1️⃣ 2.3-develop: :one: labels Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.3-develop: exclude 2.3-develop: exclude
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants