Skip to content

#108 Enhance doc for ThisInTemplate rule #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 29, 2019
Merged

#108 Enhance doc for ThisInTemplate rule #119

merged 1 commit into from
Jul 29, 2019

Conversation

diazwatson
Copy link
Contributor

@diazwatson diazwatson commented Jul 28, 2019 •
edited
Loading

@diazwatson diazwatson requested a review from lenaorobei July 28, 2019 23:07
@magento-cicd2
Copy link

magento-cicd2 commented Jul 28, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@chris-pook
Copy link

Thanks, this is much clearer!

@lenaorobei lenaorobei merged commit 4a1c8d2 into magento:develop Jul 29, 2019
@diazwatson diazwatson deleted the 108_EnhancementForThisInTemplateDoc branch July 29, 2019 20:10
@lenaorobei lenaorobei mentioned this pull request Jul 30, 2019
Closed
magento-devops-reposync-svc pushed a commit that referenced this pull request Nov 10, 2021
@sivaschenko
Merge pull request #119 from magento-commerce/improvements/add-php-de…
0e141b0 
…precated-function

Added deprecated function PHP 8.1 to DiscouragedFunctionSniff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lenaorobei lenaorobei lenaorobei approved these changes

Assignees

@lenaorobei lenaorobei

Labels
Partner: Space 48 partners-contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@diazwatson @magento-cicd2 @chris-pook @lenaorobei @magento-engcom-team