Skip to content

Commit bc5ecae

Browse files
MAGECLOUD-3582: [Cloud Docker] Default path during bash connection sh… (#24)
1 parent daf1afe commit bc5ecae

File tree

12 files changed

+81
-38
lines changed

12 files changed

+81
-38
lines changed

.github/ISSUE_TEMPLATE.md

Lines changed: 35 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,35 @@
1+
<!---
2+
Thank you for contributing to Magento.
3+
To help us process this issue we recommend that you add the following information:
4+
- Summary of the issue,
5+
- Information on your environment,
6+
- Steps to reproduce,
7+
- Expected and actual results,
8+
9+
Please also have a look at our guidelines article before adding a new issue https://github.com/magento/magento2/wiki/Issue-reporting-guidelines
10+
-->
11+
12+
### Preconditions
13+
<!---
14+
Please provide as detailed information about your environment as possible.
15+
For example Magento version, tag, HEAD, PHP & MySQL version, etc..
16+
-->
17+
1.
18+
2.
19+
20+
### Steps to reproduce
21+
<!---
22+
It is important to provide a set of clear steps to reproduce this bug.
23+
If relevant please include code samples
24+
-->
25+
1.
26+
2.
27+
3.
28+
29+
### Expected result
30+
<!--- Tell us what should happen -->
31+
1. [Screenshots, logs or description]
32+
33+
### Actual result
34+
<!--- Tell us what happens instead -->
35+
1. [Screenshots, logs or description]

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 35 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,35 @@
1+
<!---
2+
Thank you for contributing to Magento.
3+
To help us process this pull request we recommend that you add the following information:
4+
- Summary of the pull request,
5+
- Issue(s) related to the changes made,
6+
- Manual testing scenarios,
7+
-->
8+
9+
<!--- Please provide a general summary of the Pull Request in the Title above -->
10+
11+
### Description
12+
<!---
13+
Please provide a description of the changes proposed in the pull request.
14+
Letting us know what has changed and why it needed changing will help us validate this pull request.
15+
-->
16+
17+
### Fixed Issues (if relevant)
18+
<!---
19+
If relevant, please provide a list of fixed issues in the format magento/ece-tools#<issue_number>.
20+
There could be 1 or more issues linked here and it will help us find some more information about the reasoning behind this change.
21+
-->
22+
1. magento/magento-cloud-docker#<issue_number>: Issue title
23+
2. ...
24+
25+
### Manual testing scenarios
26+
<!---
27+
Please provide a set of unambiguous steps to test the proposed code change.
28+
Giving us manual testing scenarios will help with the processing and validation process.
29+
-->
30+
1. ...
31+
2. ...
32+
33+
### Contribution checklist
34+
- [ ] Pull request has a meaningful description of its purpose
35+
- [ ] All commits are accompanied by meaningful commit messages

README.md

Lines changed: 1 addition & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ Inspired by [meanbee/docker-magento2](https://github.com/meanbee/docker-magento2
1818

1919
## Installation
2020

21-
1. To be able to use this Docker configuration, you must have cloned [Magento Cloud](https://github.com/magento/magento-cloud) project
21+
1. To be able to use this Docker configuration, you must have cloned [Magento Cloud](https://github.com/magento/magento-cloud) project
2222
1. Follow instruction on [DevDocs](https://devdocs.magento.com/guides/v2.2/cloud/reference/docker-config.html)
2323

2424
## Generating new PHP configuration
@@ -33,26 +33,6 @@ Where:
3333

3434
- `version`: Version of PHP to be generated
3535

36-
## Executing commands
37-
38-
### Connecting to CLI container
39-
40-
```bash
41-
docker-compose run cli bash
42-
```
43-
44-
### Running Magento command
45-
46-
```bash
47-
docker-compose run cli magento-command
48-
```
49-
50-
### Running ECE-Tools command
51-
52-
```bash
53-
docker-compose run cli ece-command
54-
```
55-
5636
[ico-dockerbuild]: https://img.shields.io/docker/build/magento/magento-cloud-docker-php.svg?style=flat-square
5737
[ico-downloads]: https://img.shields.io/docker/pulls/magento/magento-cloud-docker-php.svg?style=flat-square
5838
[ico-dockerstars]: https://img.shields.io/docker/stars/magento/magento-cloud-docker-php.svg?style=flat-square

data/php-cli/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ RUN pecl install -o -f xdebug
3131

3232
ENV PHP_MEMORY_LIMIT 2G
3333
ENV PHP_ENABLE_XDEBUG false
34-
ENV MAGENTO_ROOT /var/www/magento
34+
ENV MAGENTO_ROOT /app
3535
ENV DEBUG false
3636
ENV MAGENTO_RUN_MODE production
3737

data/php-fpm/Dockerfile

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,13 +19,11 @@ RUN docker-php-ext-configure \
1919

2020
# Install required PHP extensions
2121
RUN docker-php-ext-install {%extensions%}
22-
2322
RUN pecl install -o -f xdebug
2423

2524
ENV PHP_MEMORY_LIMIT 2G
2625
ENV PHP_ENABLE_XDEBUG false
27-
ENV MAGENTO_ROOT /var/www/magento
28-
26+
ENV MAGENTO_ROOT /app
2927
ENV DEBUG false
3028

3129
COPY etc/php-xdebug.ini /usr/local/etc/php/conf.d/zz-xdebug-settings.ini

nginx/1.9/Dockerfile

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,11 +9,12 @@ EXPOSE 80 443
99
ENV UPLOAD_MAX_FILESIZE 64M
1010
ENV FPM_HOST fpm
1111
ENV FPM_PORT 9000
12-
ENV MAGENTO_ROOT /var/www/magento
12+
ENV MAGENTO_ROOT /app
1313
ENV MAGENTO_RUN_MODE production
1414
ENV DEBUG false
1515

1616
RUN ["chmod", "+x", "/usr/local/bin/docker-environment"]
1717

1818
ENTRYPOINT ["/usr/local/bin/docker-environment"]
19+
1920
CMD ["nginx", "-g", "daemon off;"]

php/7.0-cli/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ RUN pecl install -o -f xdebug
3131

3232
ENV PHP_MEMORY_LIMIT 2G
3333
ENV PHP_ENABLE_XDEBUG false
34-
ENV MAGENTO_ROOT /var/www/magento
34+
ENV MAGENTO_ROOT /app
3535
ENV DEBUG false
3636
ENV MAGENTO_RUN_MODE production
3737

php/7.0-fpm/Dockerfile

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,13 +19,11 @@ RUN docker-php-ext-configure \
1919

2020
# Install required PHP extensions
2121
RUN docker-php-ext-install dom gd intl mbstring pdo_mysql xsl zip bcmath soap sockets opcache mcrypt pcntl
22-
2322
RUN pecl install -o -f xdebug
2423

2524
ENV PHP_MEMORY_LIMIT 2G
2625
ENV PHP_ENABLE_XDEBUG false
27-
ENV MAGENTO_ROOT /var/www/magento
28-
26+
ENV MAGENTO_ROOT /app
2927
ENV DEBUG false
3028

3129
COPY etc/php-xdebug.ini /usr/local/etc/php/conf.d/zz-xdebug-settings.ini

php/7.1-cli/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ RUN pecl install -o -f xdebug
3131

3232
ENV PHP_MEMORY_LIMIT 2G
3333
ENV PHP_ENABLE_XDEBUG false
34-
ENV MAGENTO_ROOT /var/www/magento
34+
ENV MAGENTO_ROOT /app
3535
ENV DEBUG false
3636
ENV MAGENTO_RUN_MODE production
3737

php/7.1-fpm/Dockerfile

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,13 +19,11 @@ RUN docker-php-ext-configure \
1919

2020
# Install required PHP extensions
2121
RUN docker-php-ext-install dom gd intl mbstring pdo_mysql xsl zip bcmath soap sockets opcache mcrypt pcntl
22-
2322
RUN pecl install -o -f xdebug
2423

2524
ENV PHP_MEMORY_LIMIT 2G
2625
ENV PHP_ENABLE_XDEBUG false
27-
ENV MAGENTO_ROOT /var/www/magento
28-
26+
ENV MAGENTO_ROOT /app
2927
ENV DEBUG false
3028

3129
COPY etc/php-xdebug.ini /usr/local/etc/php/conf.d/zz-xdebug-settings.ini

0 commit comments

Comments
 (0)