MAGECLOUD-3967: Add static and unit tests to magento-cloud-components #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shiftedreality
suggested changes
Oct 1, 2019
| - if [ $TRAVIS_SECURE_ENV_VARS == "true" ]; then composer config http-basic.repo.magento.com ${REPO_USERNAME} ${REPO_PASSWORD}; fi; | ||
| - if [ $TRAVIS_SECURE_ENV_VARS == "true" ]; then composer config github-oauth.github.com ${GITHUB_TOKEN}; fi; | ||
| - composer config repositories.magento composer https://repo.magento.com/ | ||
| - composer require "magento/framework:*" --no-update |
There was a problem hiding this comment.
This will fail without keys, don't you want to add if statement?
There was a problem hiding this comment.
It's ok if it will fail, without "magento/framework:*" package test scripts won't run anyway.
| "@phpunit" | ||
| ], | ||
| "phpstan": "phpstan analyse -c Test/static/phpstan.neon", | ||
| "phpcs": "phpcs ./ --standard=Test/static/phpcs-ruleset.xml -p -n", |
There was a problem hiding this comment.
Let's add Sniffs from ECE-Tools
.travis.yml
Outdated
|
|
||
| env: | ||
| matrix: | ||
| - TEST_SUITE=static-unit XDEBUG=true |
There was a problem hiding this comment.
Yo don't need matrix, having only 1 variation
NadiyaS
reviewed
Oct 1, 2019
| @@ -21,8 +21,7 @@ class UrlFixer | |||
| */ | |||
| public function run(Store $store, $url): string | |||
| { | |||
| if ( | |||
| ($store->getForceDisableRewrites() || !$store->getConfig(Store::XML_PATH_USE_REWRITES)) | |||
| if (($store->getForceDisableRewrites() || !$store->getConfig(Store::XML_PATH_USE_REWRITES)) | |||
| && strpos($url, '/magento/') !== false | |||
There was a problem hiding this comment.
I would also create task to core to fix this issue
NadiyaS
approved these changes
Oct 1, 2019
shiftedreality
suggested changes
Oct 1, 2019
| - composer update -n --no-suggest | ||
|
|
||
| script: | ||
| - if [ "$TEST_SUITE" == "static-unit" ]; then ./Test/static/static-travis.sh; fi |
There was a problem hiding this comment.
This must be in tests directory
There was a problem hiding this comment.
Why must? it will be strange to have Test and tests directories on one level.
shiftedreality
approved these changes
Oct 4, 2019
shiftedreality
added
Progress: approved
magento-devops-reposync-svc
pushed a commit
that referenced
this pull request
Mar 23, 2022
Merge develop into 1.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://magento2.atlassian.net/browse/MAGECLOUD-3967