#2082: Minor coding style fixes

Author: ishakhsuvarov

InventoryInStorePickup/Model/ResourceModel/OrderPickupLocation/GetPickupLocationByOrderId.php

@@ -14,7 +14,8 @@
  */
 class GetPickupLocationByOrderId
 {
-    private const ORDER_ID        = 'order_id';
+    private const ORDER_ID = 'order_id';
+
     private const PICKUP_LOCATION_CODE = 'pickup_location_code';
 
     /**
@@ -23,8 +24,6 @@ class GetPickupLocationByOrderId
     private $connection;
 
     /**
-     * GetPickupLocationByOrderId constructor.
-     *
      * @param \Magento\Framework\App\ResourceConnection $connection
      */
     public function __construct(
@@ -40,15 +39,13 @@ public function __construct(
      *
      * @return string|null
      */
-    public function execute(int $orderId):?string
+    public function execute(int $orderId): ?string
     {
         $connection = $this->connection->getConnection();
         $table = $this->connection->getTableName('inventory_pickup_location_order');
 
         $select = $connection->select()
-             ->from($table, [
-                     self::PICKUP_LOCATION_CODE => self::PICKUP_LOCATION_CODE
-             ])
+             ->from($table, [self::PICKUP_LOCATION_CODE => self::PICKUP_LOCATION_CODE])
              ->where(self::ORDER_ID . '= ?', $orderId)
              ->limit(1);
 

InventoryInStorePickup/Model/ResourceModel/OrderPickupLocation/SaveOrderPickupLocation.php

@@ -14,7 +14,7 @@
  */
 class SaveOrderPickupLocation
 {
-    private const ORDER_ID        = 'order_id';
+    private const ORDER_ID  = 'order_id';
     private const PICKUP_LOCATION_CODE = 'pickup_location_code';
 
     /**
@@ -41,7 +41,7 @@ public function __construct(
      *
      * @return void
      */
-    public function execute(int $orderId, string $pickupLocationCode):void
+    public function execute(int $orderId, string $pickupLocationCode): void
     {
         $connection = $this->connection->getConnection();
         $table = $this->connection->getTableName('inventory_pickup_location_order');

InventoryInStorePickup/Plugin/Sales/Order/GetPickupLocationForOrderPlugin.php

@@ -28,9 +28,7 @@ class GetPickupLocationForOrderPlugin
     private $getPickupLocationByOrderId;
 
     /**
-     * GetPickupLocationForOrderPlugin constructor.
-     *
-     * @param OrderExtensionFactory      $orderExtensionFactory
+     * @param OrderExtensionFactory $orderExtensionFactory
      * @param GetPickupLocationByOrderId $getPickupLocationByOrderId
      */
     public function __construct(
@@ -42,16 +40,16 @@ public function __construct(
     }
 
     /**
+     * Add Pickup Location Code extension attribute when loading Order with OrderRepository.
+     *
      * @param OrderRepositoryInterface $orderRepository
-     * @param OrderInterface           $order
+     * @param OrderInterface $order
      *
      * @return OrderInterface
      * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
-    public function afterGet(
-        OrderRepositoryInterface $orderRepository,
-        OrderInterface $order
-    ):OrderInterface {
+    public function afterGet(OrderRepositoryInterface $orderRepository, OrderInterface $order): OrderInterface
+    {
         $extension = $order->getExtensionAttributes();
 
         if (empty($extension)) {

InventoryInStorePickup/Plugin/Sales/Order/SavePickupLocationForOrderPlugin.php

@@ -22,8 +22,6 @@ class SavePickupLocationForOrderPlugin
     private $saveOrderPickupLocation;
 
     /**
-     * SavePickupLocationForOrderPlugin constructor.
-     *
      * @param SaveOrderPickupLocation $saveOrderPickupLocation
      */
     public function __construct(SaveOrderPickupLocation $saveOrderPickupLocation)
@@ -32,9 +30,11 @@ public function __construct(SaveOrderPickupLocation $saveOrderPickupLocation)
     }
 
     /**
+     * Save Order to Pickup Location relation when saving the order.
+     *
      * @param \Magento\Sales\Api\OrderRepositoryInterface $orderRepository
-     * @param \Magento\Sales\Api\Data\OrderInterface      $result
-     * @param \Magento\Sales\Api\Data\OrderInterface      $entity
+     * @param \Magento\Sales\Api\Data\OrderInterface $result
+     * @param \Magento\Sales\Api\Data\OrderInterface $entity
      *
      * @return \Magento\Sales\Api\Data\OrderInterface
      * @SuppressWarnings(PHPMD.UnusedFormalParameter)