Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Update Magento Cloud Docker instructions for adding custom PHP extensions #8145

Merged

Conversation

meker12
Copy link
Contributor

@meker12 meker12 commented Oct 28, 2020

Purpose of this pull request

Clean up instructions for adding PHP extensions submitted in PR #7929.

  • Move extension configuration attribute descriptions and examples
    to a separate section
  • Clean up procedure steps for adding extension

Affected DevDocs pages

https://devdocs.magento.com/cloud/docker/docker-extend.html#php-extension-configuration-reference

whatsnew
Updated Magento Cloud Docker instructions for adding custom PHP extensions.

arhiopterecs and others added 2 commits October 5, 2020 13:55
* [Doc] Adding new PHP extensions #155

* Update src/cloud/docker/docker-extend.md


Co-authored-by: Barny Shergold <barny.shergold@vaimo.com>
Co-authored-by: Margaret Eker <meker@adobe.com>
- Move extension configuration attribute descriptions and examples
to a separate section
- Clean up procedure steps for adding extension
@meker12 meker12 requested review from hguthrie, omiroshnichenko and arhiopterecs and removed request for omiroshnichenko October 28, 2020 20:34
@meker12 meker12 self-assigned this Oct 28, 2020
@meker12 meker12 added 2.x Internal Dev Differentiates work between community and Magento staff labels Oct 28, 2020
@meker12 meker12 added Technical Updates to the code or processes that alter the technical content of the doc and removed Progress: review labels Oct 28, 2020
meker12 and others added 4 commits October 28, 2020 15:43
…ation' of github.com:magento/devdocs into mae-mcloud-6998-docker-php-customization-updates-integration
Co-authored-by: hguthrie <hguthrie@users.noreply.github.com>
meker12 and others added 2 commits October 29, 2020 13:14
Co-authored-by: hguthrie <hguthrie@users.noreply.github.com>
…ation' of github.com:magento/devdocs into mae-mcloud-6998-docker-php-customization-updates-integration
@meker12 meker12 requested a review from hguthrie October 29, 2020 18:59
meker12 and others added 2 commits October 29, 2020 16:27
Co-authored-by: hguthrie <hguthrie@users.noreply.github.com>
@meker12
Copy link
Contributor Author

meker12 commented Oct 29, 2020

running tests

@meker12 meker12 merged commit 751c3f1 into master Oct 29, 2020
@ghost
Copy link

ghost commented Oct 29, 2020

Hi @meker12, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@meker12 meker12 deleted the mae-mcloud-6998-docker-php-customization-updates-integration branch October 29, 2020 22:14
bdenham pushed a commit that referenced this pull request Oct 30, 2020
…ions (#8145)

* [Doc] Adding new PHP extensions #155 (#7929)

* Clean up instructions for adding PHP extensions
- Move extension configuration attribute descriptions and examples
to a separate section
* Fixed markdown syntax
* Fix link definitions
* Fix link syntax

* Apply suggestions from code review

Co-authored-by: Yevhen Miroshnychenko <miroshny@adobe.com>
Co-authored-by: Barny Shergold <barny.shergold@vaimo.com>
Co-authored-by: hguthrie <hguthrie@users.noreply.github.com>
bdenham added a commit that referenced this pull request Nov 4, 2020
* MCLOUD-6939: Errors occur running magento commands in composer cloud docker installation (#8007)

* Added variable to skip composer dump-autoload command processing when deploying a Magento Cloud project to a Cloud Docker environment.

* MCLOUD-7072: Add CLI command for generating .magento.env.yaml (#8040)

* MCLOUD-7072: Add CLI commands for creating and updating .magento.env.yaml
* Apply suggestions from code review
Co-authored-by: Barny Shergold <barny.shergold@vaimo.com>
Co-authored-by: Margaret Eker <meker@adobe.com>

* MCLOUD-6805: ECE-Tools release notes

WIP: updating variables

* MCLOUD-6805: ECE-Tools release notes

First draft

* MCLOUD-6805: ECE-Tools release notes

Fixed double slash on link

* added links to two  hot fixes

* Update services-mysql.md (#8144)

Co-authored-by: Margaret Eker <meker@adobe.com>

* Update Magento Cloud Docker instructions for adding custom PHP extensions (#8145)

* [Doc] Adding new PHP extensions #155 (#7929)

* Clean up instructions for adding PHP extensions
- Move extension configuration attribute descriptions and examples
to a separate section
* Fixed markdown syntax
* Fix link definitions
* Fix link syntax

* Apply suggestions from code review

Co-authored-by: Yevhen Miroshnychenko <miroshny@adobe.com>
Co-authored-by: Barny Shergold <barny.shergold@vaimo.com>
Co-authored-by: hguthrie <hguthrie@users.noreply.github.com>

* MCLOUD-6805: ECE-Tools release notes

Updated entry for MCLOUD-7098

* MCLOUD-6805: ECE-Tools release notes

Fixed merge conflicts

* Added docs for SKIP_COMPOSER_DUMP_AUTOLOAD

* Apply suggestions from code review

Co-authored-by: Margaret Eker <meker@adobe.com>

* MCLOUD-6805: ECE-Tools release notes

Added release notes entry for #7191

* Update error-codes information with current info (#8152)

* Update error-codes information with current info

- Replaced file with error-code.md file generated from the ece-tools package

* Fixed error messages

* Add source file for generating the error code ref

Co-authored-by: Barny Shergold <barny.shergold@vaimo.com>

* Fixed comment syntax on internal note

* MCLOUD-6805: ECE-Tools release notes

Added release not for MCLOUD-7193

* MCLOUD-6805: ECE-Tools release notes

Fixed silly empty bullet

* MCLOUD-6805: ECE-Tools release notes

Per review, updated additional ece-tools docs changes that are unassociated with the release notes.

* MCLOUD-6805: ECE-Tools release notes

Per review, removed extra space from yaml code block.

* MCLOUD-6805: ECE-Tools release notes

Per review, tweaking the wording for writeable Cloud Docker environments.

* MCLOUD-6805: ECE-Tools release notes

Per review, forgot to clarify the pronoun that.

* MCLOUD-6805: ECE-Tools release notes

Per review, removed extra space, missed it first time around.

* MCLOUD-6805: ECE-Tools release notes

Ordered 'new' release note before fixed

* MCLOUD-6805: ECE-Tools release notes

Added links to documentation.

* MCLOUD-6805: ECE-Tools release notes

Added links to documentation.

* Apply suggestions from code review

Co-authored-by: Margaret Eker <meker@adobe.com>

Co-authored-by: Oleksandr Shmyheliuk <oshmyheliuk@magento.com>
Co-authored-by: maeker12 <{ID}+{username}@users.noreply.github.com>
Co-authored-by: jfrontain <frontain@adobe.com>
Co-authored-by: Andrii Shevtsov <ashevtsov@magento.com>
Co-authored-by: Margaret Eker <meker@adobe.com>
Co-authored-by: Yevhen Miroshnychenko <miroshny@adobe.com>
Co-authored-by: Barny Shergold <barny.shergold@vaimo.com>
Co-authored-by: hguthrie <hguthrie@users.noreply.github.com>
meker12 added a commit that referenced this pull request Nov 9, 2020
* ECE-Tools 2002.1.3 docs and release notes (#8161)

* MCLOUD-6939: Errors occur running magento commands in composer cloud docker installation (#8007)

* Added variable to skip composer dump-autoload command processing when deploying a Magento Cloud project to a Cloud Docker environment.

* MCLOUD-7072: Add CLI command for generating .magento.env.yaml (#8040)

* MCLOUD-7072: Add CLI commands for creating and updating .magento.env.yaml
* Apply suggestions from code review
Co-authored-by: Barny Shergold <barny.shergold@vaimo.com>
Co-authored-by: Margaret Eker <meker@adobe.com>

* MCLOUD-6805: ECE-Tools release notes

WIP: updating variables

* MCLOUD-6805: ECE-Tools release notes

First draft

* MCLOUD-6805: ECE-Tools release notes

Fixed double slash on link

* added links to two  hot fixes

* Update services-mysql.md (#8051 
* Update Magento Cloud Docker instructions for adding custom PHP extensions (#8145)

* [Doc] Adding new PHP extensions #155 (#7929)

* Clean up instructions for adding PHP extensions
- Move extension configuration attribute descriptions and examples
to a separate section
* Fixed markdown syntax
* Fix link definitions
* Fix link syntax

* Apply suggestions from code review

Co-authored-by: Yevhen Miroshnychenko <miroshny@adobe.com>
Co-authored-by: Barny Shergold <barny.shergold@vaimo.com>
Co-authored-by: hguthrie <hguthrie@users.noreply.github.com>

* MCLOUD-6805: ECE-Tools release notes

Updated entry for MCLOUD-7098

* MCLOUD-6805: ECE-Tools release notes

Fixed merge conflicts

* Added docs for SKIP_COMPOSER_DUMP_AUTOLOAD

* Apply suggestions from code review

Co-authored-by: Margaret Eker <meker@adobe.com>

* MCLOUD-6805: ECE-Tools release notes

Added release notes entry for #7191

* Update error-codes information with current info (#8152)

* Update error-codes information with current info

- Replaced file with error-code.md file generated from the ece-tools package

* Fixed error messages

* Add source file for generating the error code ref

Co-authored-by: Barny Shergold <barny.shergold@vaimo.com>

* Fixed comment syntax on internal note

* MCLOUD-6805: ECE-Tools release notes

Added release not for MCLOUD-7193

* MCLOUD-6805: ECE-Tools release notes

Fixed silly empty bullet

* MCLOUD-6805: ECE-Tools release notes

Per review, updated additional ece-tools docs changes that are unassociated with the release notes.

* MCLOUD-6805: ECE-Tools release notes

Per review, removed extra space from yaml code block.

* MCLOUD-6805: ECE-Tools release notes

Per review, tweaking the wording for writeable Cloud Docker environments.

* MCLOUD-6805: ECE-Tools release notes

Per review, forgot to clarify the pronoun that.

* MCLOUD-6805: ECE-Tools release notes

Per review, removed extra space, missed it first time around.

* MCLOUD-6805: ECE-Tools release notes

Ordered 'new' release note before fixed

* MCLOUD-6805: ECE-Tools release notes

Added links to documentation.

* MCLOUD-6805: ECE-Tools release notes

Added links to documentation.
* Apply suggestions from code review

* Cloud Docker 1.2.0 Release (#8199)

* MCLOUD-6430: Xdebug not working on Magento Cloud Docker 1.1 (#7810)
* Update src/cloud/docker/docker-development-debug.md
* MCLOUD-6898: Add option to customize port for MailHog (#7860)
* MCLOUD-6898: Add option to customize port for MailHog
* MCLOUD-6660: Add option to disable MailHog
* Update src/cloud/docker/docker-config.md
* MCLOUD-2789: [Cloud Docker] Add custom ES plugins (#7898)
* MCLOUD-2789: [Cloud Docker] Add support for adding custom ES plugins from services.yaml file to the docker-compose.yml file.
* MCLOUD-6394: Help with running MFTF test generation commands (#7995)
* MCLOUD-6394: Help with running MFTF test generation commands
* Added `--with-test` option to `build:compose` option list
* Update src/cloud/docker/docker-containers.md
  - Added test container
* Update src/cloud/docker/docker-containers-service.md
   Added `--with-test` option to `build:compose` option list
* Update Docker command help (#8197)
* Updated Docker Quick reference
- Addedd new options to the magento-docker CLI
- Added listing that shows all available options for ece-docker
build:compose command
- Added intro to Docker Compose section
* Updates for Cloud Docker 1.2.0 release (#8198)
* MCLOUD-7809 Added instructions for building custom docker-compose.yaml file
* Improved instructions for using the init-docker.sh installation script
* Updates based on review feedback
* Updated Launch developer mode instructions to add step
to apply patches before deploying to a Magento Cloud
Docker environment

Co-authored-by: Oleksandr Shmyheliuk <oshmyheliuk@magento.com>
Co-authored-by: Andrii Shevtsov <ashevtsov@magento.com>
Co-authored-by: Margaret Eker <meker@adobe.com>
Co-authored-by: Yevhen Miroshnychenko <miroshny@adobe.com>
Co-authored-by: Barny Shergold <barny.shergold@vaimo.com>
Co-authored-by: hguthrie <hguthrie@users.noreply.github.com>
Co-authored-by: Jeff Matthews <matthews.jeffery@gmail.com>
Co-authored-by: Bohdan Korablov <korablov@adobe.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
2.x hacktoberfest-accepted Internal Dev Differentiates work between community and Magento staff Progress: done Technical Updates to the code or processes that alter the technical content of the doc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants