This repository was archived by the owner on Nov 19, 2024. It is now read-only.
Clarify PHP version support and fix format errors #7042
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The | character in the version constraints caused issues rendering the callout. - Changed PHP version support from annotation to English
meker12
added
2.x
Internal Dev
meker12
commented
Apr 16, 2020
shrielenee
approved these changes
Apr 16, 2020
| @@ -10,7 +10,7 @@ functional_areas: | |||
| You can easily migrate to the {{site.data.var.ece}} platform without losing SEO rankings and traffic. Use the `magento/url-rewrite-import-export` module to redirect traffic from your old, indexed URLs to new URLs. | |||
|
|
|||
| {:.bs-callout-info} | |||
| This module supports ~7.0.13|~7.1.0|~7.2.0|~7.3.0 PHP versions and is available for Magento version 2.2.x and 2.3.x only. | |||
| This module supports the following PHP versions 7.0.13 and later patch releases and all 7.1.0 and 7.2.0 patch releases. The module is available for Magento version 2.2.x and 2.3.x only. | |||
There was a problem hiding this comment.
Could this be better by removing "the following"?
meker12
commented
Apr 16, 2020
|
running tests |
|
Hi @meker12, thank you for your contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
Fix a formatting issue in PHP version constraint information for URL rewrites module.
Affected DevDocs pages