This repository was archived by the owner on Nov 19, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Added information about the missing settings to serve Magento app from /pub
directory
#7038
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erver is being configured to serve the Magento app from the `/pub` directory.
@thiaramus thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository. |
An admin must run tests on this PR before it can be merged. |
nuzil
approved these changes
Apr 15, 2020
Thanks @thiaramus , its definitely make sense |
dobooth
suggested changes
Apr 20, 2020
…erver is being configured to serve the Magento app from the `/pub` directory.
dobooth
approved these changes
Apr 21, 2020
Thanks for the updates, @thiaramus. Can you please update your branch here and ping me when you do? Thanks. |
running tests |
dobooth
suggested changes
Apr 21, 2020
…erver is being configured to serve the Magento app from the `/pub` directory.
dobooth
approved these changes
Apr 21, 2020
running tests |
Hi @thiaramus, thank you for your contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added information about the missing settings and steps when the web server is configured to serve the Magento app from the
/pub
directory.Purpose of this pull request
There are multiple resolved issues that suggest these settings to be added to the configuration file
env.php
in order for the Magento app to properly work when being served from the/pub
directory instead of/
. I think it is necessary to add this information to DevDocs for future references.Affected DevDocs pages
Links to Magento source code