This repository was archived by the owner on Nov 19, 2024. It is now read-only.
Adding question mark when nullable value is declared #6033
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magento-engcom-team
added
Partner: Webjump
partners-contribution
|
An admin must run tests on this PR before it can be merged. |
4 tasks
ronak2ram
approved these changes
Nov 20, 2019
keharper
approved these changes
Nov 20, 2019
keharper
added
2.2.x
2.3.x
|
Thanks @rodrigowebjump |
|
Hi @rodrigowebjump, thank you for your contribution! |
Merged
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
This pull request (PR) improves the recommendation and example when adding a new constructor param
Affected DevDocs pages
https://devdocs.magento.com/guides/v2.3/contributor-guide/backward-compatible-development/
https://devdocs.magento.com/guides/v2.2/contributor-guide/backward-compatible-development/
Topic: Adding a constructor parameter
Links to Magento source code
https://www.php.net/manual/en/migration71.new-features.php
https://github.com/magento/magento2/blob/2.3/app/code/Magento/Cms/Model/Page/DataProvider.php#L59